Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QuantumOpticsSystem for creating QuantumSystem #121

Merged
merged 10 commits into from
Jun 12, 2024

Conversation

maxwell04-wq
Copy link
Contributor

Fixes #85.

  • Added a function QuantumOpticsSystem for creating a system using QuantumOptics
  • Extended a new QuantumSystem function for compatibility with QuantumOpticsSystem
  • Added tests for QuantumOpticsSystem

@maxwell04-wq
Copy link
Contributor Author

@aarontrowbridge I have tried to run the tests but it seems to stop after reaching maximum iterations. There were some conflicts initially, which I have resolved before pushing the commits.

@maxwell04-wq maxwell04-wq changed the title Add QuantumOpticsSystem for creating `QuantumSystem Add QuantumOpticsSystem for creating QuantumSystem Jun 12, 2024
@maxwell04-wq
Copy link
Contributor Author

@aarontrowbridge I believe that the PR is ready to review now. I have not added the docs yet; I need some time to document it.

@aarontrowbridge
Copy link
Collaborator

let's see if the CI runs

@maxwell04-wq
Copy link
Contributor Author

@aarontrowbridge can you confirm whether I need to create the QuantumSystem object using QuantumOpticsBase.Operator as mentioned in the PR or using QuantumObject{SparseMatrixCSC, ...} object as discussed in the call? I have implemented them both, but the latter is commented out.
Also, can you please review it before day end so that I can make any major changes before the end of UnitaryHack if necessary?

@aarontrowbridge aarontrowbridge merged commit b9139b2 into kestrelquantum:main Jun 12, 2024
3 checks passed
@aarontrowbridge
Copy link
Collaborator

this looks good thanks!

@maxwell04-wq
Copy link
Contributor Author

Awesome! This was fun; thanks for all the help:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: interface with QuantumOptics.jl
2 participants