Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Override quantum control problem defaults in problem templates #56

Closed
andgoldschmidt opened this issue Nov 29, 2023 · 1 comment
Assignees

Comments

@andgoldschmidt
Copy link
Member

Is your feature request related to a problem? Please describe.
Min time and robustness problem templates constructed from a QuantumControlProblem use the problem's constraints and objective. Sometimes, we might want to reset or change these. However, we don't care to redefine the initial trajectory, system, or other problem-specific intializations.

Describe the solution you'd like
Example,

function UnitaryRobustnessProblem(
    Hₑ::AbstractMatrix{<:Number},
    prob::QuantumControlProblem;
    constraints::Union{Vector{<:AbstractConstraint}, Nothing}=nothing,
    objective::Union{Objective, Nothing}=nothing,
    kwargs...
)

would use the problem defaults if nothing, else the provided values.

We will also need to add a default convenience objective that acts as a zero. It might also be nice to treat any usage of zero as referring to this objective, when doing addition of objectives.

@andgoldschmidt andgoldschmidt self-assigned this Nov 29, 2023
@andgoldschmidt andgoldschmidt changed the title Override quantum control problem defaults in problem templates [Feature] Override quantum control problem defaults in problem templates May 6, 2024
@andgoldschmidt
Copy link
Member Author

Closed by #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant