Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objective constructors have bad initial keyword args #63

Closed
aarontrowbridge opened this issue Dec 5, 2023 · 1 comment
Closed

Objective constructors have bad initial keyword args #63

aarontrowbridge opened this issue Dec 5, 2023 · 1 comment

Comments

@aarontrowbridge
Copy link
Collaborator

Describe the bug
Default values for objective constructors used in loading saved objectives have bad values.

Example
at line 469 in objectives.jl

function QuadraticSmoothnessRegularizer(;
	name::Symbol=nothing,
    times::AbstractVector{Int}=1:traj.T,
	R::AbstractVector{<:Real}=ones(traj.dims[name]),
	eval_hessian=true
)
@andgoldschmidt
Copy link
Member

closing because duplicate of #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andgoldschmidt @aarontrowbridge