Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Set named trajectory free time data to hold total time at final index #84

Open
1 of 9 tasks
aarontrowbridge opened this issue May 6, 2024 · 0 comments
Open
1 of 9 tasks
Assignees
Labels
enhancement New feature or request

Comments

@aarontrowbridge
Copy link
Collaborator

Feature Description

Currently the final timestep, which is not physical, is used to store the value that is used to constrain all the time steps to be equal. This feature request proposes storing the total time there instead.

Currently:
If a TimeStepsAllEqualConstraint is set, which is the default case for most problem templates, get_timesteps(traj)[end] will return the value of the total time step

Proposal:
Have get_timesteps(traj)[end] return the total time and the time step all equal constraints be changed accordingly (just need to divide total time by number of timesteps)

Importance

1 (lowest)

What does this feature affect?

  • quantum system construction
  • problem setup
  • problem solution
  • problem performance
  • solution analysis
  • plotting
  • documentation
  • tests
  • other (please specify below)

Other information

No response

@aarontrowbridge aarontrowbridge added the enhancement New feature or request label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant