-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - HELP - terraform provider kong documentation #1148
Conversation
Deploy preview for kongdocs ready! Built with commit 095c7db |
5813871
to
7e2f7f2
Compare
Hi @kevholditch , I see it appearing locally, albeit without an image: I'm able to get there by visiting |
Hi @kevholditch - I've confirmed that it is working locally, you might be clicking the "hub" link in the header which will take you to the live hub page on docs.konghq.com When running it locally you can see it at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an icon.
If you do not have a custom icon you can copy the default_icon.png
in _assets/icons/hub
and name it kevholditch_terraform-provider-kong.png
Hi Guys, I think this should show up in the Installation Page rather than in the Kong Hub, under a Terraform icon. |
@levfishbluefish added default image or do we want to move this now? As per the comment from @subnetmarco? Think you could argue it either way between deployment and installation. Personally I think its more deployment as the provider doesn't help you install or run kong it simply configures an installation of kong that is already running. The reason I put it in hub is that's where @coopr asked me to put it Happy to put it wherever is deemed best. |
@kevholditch lets go ahead and move this to the installation page |
I agree. Keep in mind that we have a Terraform module which can be used to deploy Kong as well: https://docs.konghq.com/hub/zillowgroup/kong-terraform/ I would suggest that we introduce a new category of Configuration, under which projects like these and other tools by the community, like Konga can be put. Also, @kevholditch Thank you for building the Terraform provider for Kong! 🙇 |
@subnetmarco I'll give you the final say |
We should have a "Terraform" icon in the installation page, and within that page we can have two sections: "Installing with Terraform" and "Configuring with Terraform". It's more likely for a user trying to use Kong via Terraform to do so via the Installation page and Terraform link, rather than scrolling the Hub. In fact, I would like to move all the "Deployments" in the Hub to the Installation page in a specific "Community Contributed" section. In the meanwhile, we can make that clear by adding a note to the Terraform page, but still have it visible in the installation page. |
|
Unresolved bikeshedding around an unclear contribution. We can reopen if someone wants to not only propose but implement a workable solution. |
Help
I must be missing something as my new tile is not appearing on the hub page. I'm not sure why, could someone please help
NOTE: Please read the CONTRIBUTING.md guidelines before submitting your patch,
and ensure you followed them all:
https://github.com/Kong/docs.konghq.com/blob/master/CONTRIBUTING.md
Summary
Adding deployment documentation for terraform provider kong
Full changelog
Issues resolved
Fix kevholditch/terraform-provider-kong#43
Checklist: