handle large chat sends (#369)

* handle large chat sends

* x

Author: zoom-ua

base/output.go

@@ -2,6 +2,7 @@ package base
 
 import (
 	"fmt"
+	"os"
 	"strings"
 	"time"
 
@@ -76,11 +77,65 @@ func (d *DebugOutput) ChatErrorf(convID chat1.ConvIDStr, msg string, args ...any
 }
 
 func (d *DebugOutput) ChatEcho(convID chat1.ConvIDStr, msg string, args ...any) {
-	if _, err := d.config.KBC.SendMessageByConvID(convID, msg, args...); err != nil && !IsIgnoredSendError(err) {
+	if err := d.SendMessageByConvIDOrFile(convID, "", msg, args...); err != nil && !IsIgnoredSendError(err) {
 		d.Errorf("ChatEcho: failed to send echo message: %s", err)
 	}
 }
 
+// SendMessageByConvIDOrFile sends a chat message, falling back to a file
+// attachment when the message exceeds Keybase's maximum length.
+func (d *DebugOutput) SendMessageByConvIDOrFile(convID chat1.ConvIDStr, title, msg string, args ...any) error {
+	if d.config == nil || d.config.KBC == nil {
+		return fmt.Errorf("chat not configured")
+	}
+	body := msg
+	if len(args) > 0 {
+		body = fmt.Sprintf(msg, args...)
+	}
+	if _, err := d.config.KBC.SendMessageByConvID(convID, "%s", body); err == nil ||
+		IsIgnoredSendError(err) || !IsMessageTooLongError(err) {
+		return err
+	}
+
+	filePath, err := writeTempFile(d.name, body)
+	if err != nil {
+		return err
+	}
+	GoWithRecover(d, func() {
+		defer func() {
+			time.Sleep(time.Minute)
+			d.Debug("cleaning up %s", filePath)
+			if err := os.Remove(filePath); err != nil {
+				d.Errorf("unable to clean up %s: %v", filePath, err)
+			}
+		}()
+		if _, err := d.config.KBC.SendAttachmentByConvID(convID, filePath, title); err != nil {
+			d.Errorf("failed to send attachment %s: %s", filePath, err)
+		}
+	})
+	return nil
+}
+
+func writeTempFile(namePrefix, content string) (string, error) {
+	f, err := os.CreateTemp("", namePrefix+"-*.txt")
+	if err != nil {
+		return "", err
+	}
+	path := f.Name()
+	defer func() {
+		_ = f.Close()
+	}()
+	if _, err := f.WriteString(content); err != nil {
+		_ = os.Remove(path)
+		return "", err
+	}
+	if err := f.Sync(); err != nil {
+		_ = os.Remove(path)
+		return "", err
+	}
+	return path, nil
+}
+
 func (d *DebugOutput) Trace(err *error, format string, args ...any) func() {
 	msg := fmt.Sprintf(format, args...)
 	start := time.Now()
@@ -94,6 +149,11 @@ func IsIgnoredSendError(err error) bool {
 	return IsDeletedConvError(err) || IsEphemeralKeyError(err)
 }
 
+func IsMessageTooLongError(err error) bool {
+	// error created in https://github.com/keybase/client/blob/7d6aa64f3fba66adba7a5dd1cc7c523d5086a548/go/chat/msgchecker/plaintext_checker.go#L50
+	return err != nil && strings.Contains(err.Error(), "exceeds the maximum length")
+}
+
 func IsDeletedConvError(err error) bool {
 	// error created in https://github.com/keybase/client/blob/1985b18c4e7659bede1d4a2e68e4f68467acebc6/go/client/chat_svc_handler.go#L1407
 	// error created in https://github.com/keybase/keybase/blob/9a82c96231ea2c6132532002e58bac80849265e6/go/chatbase/storage/sql_chat.go#L2324

webhookbot/webhookbot/http.go

@@ -7,9 +7,6 @@ import (
 	"fmt"
 	"io"
 	"net/http"
-	"os"
-	"strings"
-	"time"
 
 	"github.com/didip/tollbooth/v8"
 	"github.com/gorilla/mux"
@@ -68,30 +65,6 @@ func (h *HTTPSrv) getMessage(r *http.Request) (string, error) {
 	return "`Error: no body found. To use a webhook URL, supply a 'msg' URL parameter, or a JSON POST body with a field 'msg'`", nil
 }
 
-func (h *HTTPSrv) safeWriteToFile(hookName, content string) (string, error) {
-	pattern := fmt.Sprintf("webhookbot-%s-*.txt", hookName)
-	file, err := os.CreateTemp("", pattern)
-	if err != nil {
-		return "", fmt.Errorf("failed to create temp file: %w", err)
-	}
-	defer func() {
-		if cerr := file.Close(); cerr != nil {
-			h.Errorf("safeWriteToFile: failed to close temp file: %s", cerr)
-		}
-	}()
-
-	if _, err := file.Write([]byte(content)); err != nil {
-		return "", fmt.Errorf("failed to write file: %w", err)
-	}
-
-	// Explicitly sync to ensure all data is written to disk before upload
-	if err := file.Sync(); err != nil {
-		return "", fmt.Errorf("failed to sync file: %w", err)
-	}
-
-	return file.Name(), nil
-}
-
 func (h *HTTPSrv) handleHook(w http.ResponseWriter, r *http.Request) {
 	vars := mux.Vars(r)
 	id := vars["id"]
@@ -114,37 +87,8 @@ func (h *HTTPSrv) handleHook(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	h.Stats.Count("handle - success")
-	if _, err := h.Config().KBC.SendMessageByConvID(hook.ConvID, "[hook: *%s*]\n\n%s", hook.Name, msg); err != nil {
-		if base.IsDeletedConvError(err) {
-			h.Debug("handleHook: failed to send message: %s", err)
-			return
-		}
-
-		// error created in https://github.com/keybase/client/blob/7d6aa64f3fba66adba7a5dd1cc7c523d5086a548/go/chat/msgchecker/plaintext_checker.go#L50
-		if strings.Contains(err.Error(), "exceeds the maximum length") {
-			filePath, err := h.safeWriteToFile(hook.Name, msg)
-			if err != nil {
-				h.Errorf("failed to write attachment file: %s", err)
-				return
-			}
-			base.GoWithRecover(h.DebugOutput, func() {
-				defer func() {
-					// Cleanup after the file is sent.
-					time.Sleep(time.Minute)
-					h.Debug("cleaning up %s", filePath)
-					if err = os.Remove(filePath); err != nil {
-						h.Errorf("unable to clean up %s: %v", filePath, err)
-					}
-				}()
-				title := fmt.Sprintf("[hook: *%s*]", hook.Name)
-				if _, err := h.Config().KBC.SendAttachmentByConvID(hook.ConvID, filePath, title); err != nil {
-					h.Errorf("failed to send attachment %s: %s", filePath, err)
-					return
-				}
-			})
-			return
-		}
-
+	title := fmt.Sprintf("[hook: *%s*]", hook.Name)
+	if err := h.SendMessageByConvIDOrFile(hook.ConvID, title, "%s\n\n%s", title, msg); err != nil {
 		h.Debug("handleHook: failed to send message: %s", err)
 	}
 }