From 2d283d4d1376730ecca600ee882a87541a86928d Mon Sep 17 00:00:00 2001 From: Eberhard Beilharz Date: Thu, 4 Apr 2024 16:30:50 +0200 Subject: [PATCH 1/2] chore(linux): Show failed job for next Ubuntu version as failed This change shows failed package builds for the next Ubuntu version as failed. With the last change it still showed as green in the overview, despite my experiments. Turns out it depends where you put the `continue-on-error: true` statement: if it's in the `steps` section it'll show up green, if you put it in the job's metadata it'll work as expected and show up as failed. --- .github/workflows/deb-packaging.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/deb-packaging.yml b/.github/workflows/deb-packaging.yml index 48a251775e6..8752fe316db 100644 --- a/.github/workflows/deb-packaging.yml +++ b/.github/workflows/deb-packaging.yml @@ -112,12 +112,12 @@ jobs: binary_packages_released: name: Build binary packages for released versions needs: sourcepackage + runs-on: ubuntu-latest strategy: fail-fast: true matrix: dist: [focal, jammy, mantic] - runs-on: ubuntu-latest steps: - name: Checkout uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1 @@ -137,12 +137,13 @@ jobs: binary_packages_unreleased: name: Build binary packages for next Ubuntu version needs: sourcepackage + continue-on-error: true + runs-on: ubuntu-latest strategy: fail-fast: true matrix: dist: [noble] - runs-on: ubuntu-latest steps: - name: Checkout uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1 @@ -151,7 +152,6 @@ jobs: sparse-checkout: '.github/actions/' - name: Build - continue-on-error: true uses: ./.github/actions/build-binary-packages with: dist: ${{ matrix.dist }} From d1573444dcc1205b5c604db1ebfc99a16533aa31 Mon Sep 17 00:00:00 2001 From: Eberhard Beilharz Date: Thu, 4 Apr 2024 16:50:14 +0200 Subject: [PATCH 2/2] chore(linux): Update gha-ubuntu-packaging action This removes warnings about deprecated Node.js 16. --- .github/actions/build-binary-packages/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/build-binary-packages/action.yml b/.github/actions/build-binary-packages/action.yml index 79863764270..27f02461214 100644 --- a/.github/actions/build-binary-packages/action.yml +++ b/.github/actions/build-binary-packages/action.yml @@ -31,7 +31,7 @@ runs: path: artifacts/keyman-srcpkg - name: Build - uses: sillsdev/gha-ubuntu-packaging@1f4b7e7eacb8c82a4d874ee2c371b9bfef7e16ea # v1.0 + uses: sillsdev/gha-ubuntu-packaging@7b56f50d5d5537e9e9cafd3f6139ec6da69cfcda # v1.1 with: dist: "${{ inputs.dist }}" platform: "${{ inputs.arch }}"