-
-
Notifications
You must be signed in to change notification settings - Fork 128
maint(common): update fast-json-patch to ^3.1.1 #13901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The `fast-json-parser` package is needed by `ajv-cli`, which is used during common/web/types/build.sh configure. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
|
Can you also submit a PR upstream to ajv? ajv looks somewhat unmaintained; the suggested patch on ajv-cli is a good stop-gap but ideal is to have the upstream up-to-date. |
See ajv-validator/ajv-cli#227 - it's been waiting for approval for a while. Seems to be dead, but someone's forked the project and is maintaining it more actively. Found it via the last comment to that PR: https://github.com/jirutka/ajv-cli |
Shame, picking up a maintainer is better than a fork... Hesitant to switch to the fork. |
|
Changes in this pull request will be available for download in Keyman version 19.0.41-alpha |
The
fast-json-parserpackage is needed byajv-cli, which is used during common/web/types/build.sh configure.Found this approach via a comment on ajv-validator/ajv-cli#237.
Remaining
npm auditissues after this fix:... and updating Sentry (for web/) is potentially something far more involved.
Test-bot: skip