-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDEA] Support exclusion file filters #728
Comments
Hey @debanjum I'd like to work on this issue. If it's still unassigned, could you please assign it to me? |
Hi @ashanviii , that'd be great! Let us know if you need any help with implementing the feature? |
Hi @debanjum ! Is this item still available to work on? I would like to have it assigned to me. Thanks! |
@olanna12 , do go for it. Given @ashanviii has unassigned themselves, I'm assuming it's up for grabs. |
The file needs to be excluded, right. file filter needs to be updated |
I'm working on this file-exclusion. Feel free to contribute or suggest changes |
@olanna12 , are you working on this? If not, @srikary12 can take it up. Let's wait a day or two for olanna12 to respond before changing the assignment. |
@sabaimran Can I take this up? |
Sure, transferring to @srikary12 since others haven't responded. Let me know if you have questions! |
hey @sabaimran , i see the pull request has not been merged since a month. whats the status? |
@shantanuSakpal, I'm fixing some issues on the PR. I was occupied last few days. Will try to fix the issues by this weekend. |
### Overview Support exclude file filter in user search queries ### Details - All of the exclude file filter terms need to be satisfied - Any one of the include file filter terms should be satisfied ### Example - **Search Query**: *what happened yesterday? -file:"tasks.org" -file:"work.md" file:"diary.org" file:"journal.org* - **Behavior**: Query will try find relevant notes in any of `journal.org` or `diary.org` and not in `tasks.org` and not in `work.md` ### Details * Add support for exclusion file filters * Translate file filter to valid Django DB entry filter regex * Exclude all files when multiple exclude file filter in query Previously we were applying an "Or" filter, which would exclude any file mentioned in a query with multiple exclude file filter. This is not what we naturally mean when we ask excluding a file in a query * Rename, rearrange, deduplicate and add file filter tests Closes #728 --------- Co-authored-by: Debanjum Singh Solanky <[email protected]>
Describe the feature you'd like
Ability to exclude files or folders from being used by Khoj for a specific chat message
Example message:
"Where did jeremy grow up? -file:/home/susan/*.md"
should result in exclude susan's markdown notes when looking up answersKhoj currently only supports inclusion file filters like
"Where did jeremy grow up? file:/home/jeremy/*.md"
The text was updated successfully, but these errors were encountered: