Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg use tags also have href attributes #27

Open
leroix opened this issue Apr 6, 2017 · 5 comments
Open

svg use tags also have href attributes #27

leroix opened this issue Apr 6, 2017 · 5 comments

Comments

@leroix
Copy link

leroix commented Apr 6, 2017

It's common to use svg's in anchor tags with xlink'ing. Occassionally, a click will target the use tag, and since it has an href attribute, recur-href will stop there instead of iterating up to the anchor tag.

Shouldn't the recur-href function check whether the element is an anchor tag?

related: #15

@livtanong
Copy link

Running into this issue as well. My urls are unexpectedly being set to [object SVGAnimatedString].

@livtanong
Copy link

@wavejumper I saw that you replied to this thread (was notified via email), but it seems to be missing. You mentioned updating the logic, but I haven't seen any updates of this nature on master.

@wavejumper
Copy link
Member

@levitanong Yeah, sorry about that! I only understood the nature of this problem after I made my comment.

I'll merge in @leroix PR this weekend when I get the chance. Apologies for the delay

@livtanong
Copy link

Oh okay! Awesome. Thanks guys!

@bleakley
Copy link

area tags also have href attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants