Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object doesn't support property or method 'closest' #32

Open
colindresj opened this issue Oct 5, 2017 · 2 comments · May be fixed by #37
Open

Object doesn't support property or method 'closest' #32

colindresj opened this issue Oct 5, 2017 · 2 comments · May be fixed by #37

Comments

@colindresj
Copy link

Looks like pushy is using a function that isn't supported in IE. Might want to consider a polyfill or relying on .parentNode instead.

Happy to put together a pull request based on any input.

@jwr
Copy link

jwr commented Feb 12, 2018

I just turned on client-side application logging and discovered that some of my users experience app crashes because of this. As it is now, pushy does not work with Internet Explorer.

@jwr
Copy link

jwr commented Mar 16, 2018

Ok, so since this completely breaks IE for applications that use pushy, here's a quick workaround I've found:

In your compiler options add:

                                        :install-deps true
                                        :npm-deps {"element-closest" "2.0.2"}

And add ["element-closest"] to :require somewhere in your app. This will install the element-closest polyfill that provides the closest method to browsers that do not support it. Requires a recent ClojureScript with :npm-deps support.

@camdez camdez linked a pull request Mar 28, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants