Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some comments in the backporting pull request #70

Closed
lampajr opened this issue Jul 27, 2023 · 4 comments · Fixed by #71
Closed

Add some comments in the backporting pull request #70

lampajr opened this issue Jul 27, 2023 · 4 comments · Fixed by #71
Assignees
Labels
enhancement New feature or request

Comments

@lampajr
Copy link
Member

lampajr commented Jul 27, 2023

Allow users to add extra information in the generated backporting pull request as comments.

@lampajr lampajr added the enhancement New feature or request label Jul 27, 2023
@lampajr lampajr self-assigned this Jul 27, 2023
@tarilabs
Copy link
Member

for instance here:
Screenshot 2023-07-27 at 11 30 31

I did not realize what to do, beyond reviewing the code as requested by the bot.

Then Tristan here shown me it was enough to trigger the CI manually: https://github.com/kiegroup/drools/pull/5408#issuecomment-1653022109

So in addition to

Backport: #5406

it would be helpful to add some further instructions such as "please manually approve/run the CI with the usual comments"

@lampajr
Copy link
Member Author

lampajr commented Jul 27, 2023

@tarilabs thanks a lot for the example, in the specific case you mentioned - as user - would you prefer to have the further instructions as new separated comment in the pr or as part of the pr description?

@tarilabs
Copy link
Member

_ as part of the pr description_ would work perfectly for me, please

@tarilabs
Copy link
Member

ie: just before/after the "Backport: #5406" and not in the <details/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants