Drop dead code

[sailingKieler]

KLighD/plugins/de.cau.cs.kieler.klighd.piccolo/src/de/cau/cs/kieler/klighd/piccolo/internal/controller/KLabelRenderingController.java

Lines 96 to 102 in d21bf90

	// Transfer selectability from KLabel to KText to properly handle the selection handlers
	// Should only apply if the KText is not configured but KLabel is configured
	if (!kText.getProperties().contains(KlighdProperties.NOT_SELECTABLE)
	&& getGraphElement().getProperties().contains(KlighdProperties.NOT_SELECTABLE)) {
	kText.setProperty(KlighdProperties.NOT_SELECTABLE,
	getGraphElement().getProperty(KlighdProperties.NOT_SELECTABLE));
	}

@a-sr @NiklasRentzCAU I would like to remove this code, as getGraphElement().getProperties().contains(KlighdProperties.NOT_SELECTABLE) will never be satisfied. getProperties() returns an EMap<IProperty<?>, Object> containing IPropertyToObjectMapImpls. Hence, KlighdProperties.NOT_SELECTABLE will never be "contained".

Also from a conceptual point of view I don't like these kind of built-in magics.
If I remember right, back then I decided leave the freedom of fine-grained control on the selectability of labels and text fields to the diagram synthesis developers on purpose.

Any objections?

[NiklasRentzCAU]

I only ever used the suppression of the selectability on KTexts and other rendering elements, not on graph element such as labels. As far as I can see this is also never used for labels anywhere in our code, so this could just be removed safely.

[a-sr]

I think the idea was that you usually don't need to create a KText for a label and this way you can configure the selectability of the automatically created KText via the label. However, if it does not work, then we probably don't use it, hence you can delete it.

[sailingKieler]

that you usually don't need to create a KText for a label and this way you can configure the selectability of the automatically created KText via the label

Sure. However, I would expect this kind of thing in some convenience API like the KLabelExtensions, not in the runtime.

I'll take care about it together with #43.