Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate implementations between Piccolo/Eclipse UI and LSP #59

Open
NiklasRentzCAU opened this issue Jul 23, 2020 · 0 comments
Labels
enhancement New feature or request LSP Affect the klighd language server.

Comments

@NiklasRentzCAU
Copy link
Member

For the implementation of the KLighD language server extension and diagram server, some implementations used in Piccolo and the UI plugins using Eclipse UI have been duplicated to avoid unwanted dependencies from the lsp bundle to Piccolo or Eclipse UI, and because the implementations slightly differ in how information is stored. For consistency and to avoid code duplications, these should be moved to a more central bundle and reused in both cases.

This includes the following implementations:

  • Micro Layout (RenderingPreparer class in lsp and AbstractKGERenderingController class in piccolo)
  • Updating a diagram (KGraphDiagramUpdater#prepareModel in lsp and DiagramView#doUpdateDiagram in klighd.ui.view)
  • Storing the state of SynthesisOptions (KGraphDiagramUpdater#storeCurrentSynthesisOptions in lsp and DiagramView#storeCurrentSynthesisOptions in klighd.ui.view)
@NiklasRentzCAU NiklasRentzCAU added enhancement New feature or request LSP Affect the klighd language server. labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request LSP Affect the klighd language server.
Projects
None yet
Development

No branches or pull requests

1 participant