Force PARENT edge coords in the JSON editor.
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that Sprotty is able to draw the graph correctly.
4 tasks
Conditional operator unnecessary
|
Question: Should it be made conditional on the selected ELK version? I could move the added lines a bit lower, under here: elk-live/client/src/json/editor.ts Line 102 in 439ce96 and make them kick in only if the numerical value of The reason for doing so would be to avoid passing earlier versions of ELK a property, But in testing, it seems to me that they don't care. All earlier versions seem to work just fine, even though I'm passing them an unknown property. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that Sprotty is able to draw the graph correctly, and is a part of the solution to eclipse/elk#901 .
It also resolves #8.
Note however that it won't do anything until
elk-liveis using a version of ELK that incorporates eclipse/elk#1071 .It appears to be consistent with older/current versions of ELK, i.e. they appear to simply ignore the new property, and their behavior is unchanged.