Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching y-axis ticks to labels is often incorrect #8

Closed
kitchensjn opened this issue Jun 6, 2023 · 2 comments
Closed

Matching y-axis ticks to labels is often incorrect #8

kitchensjn opened this issue Jun 6, 2023 · 2 comments
Labels
bug Something isn't working
Milestone
0.0.2

Comments

@kitchensjn
Copy link
Owner

Sorting the ticks and labels separately runs into a lot of issues particularly when node timings are the same (ARGweaver, SLiM). I need to think of a more consistent way of sending this information into JavaScript.
@kitchensjn kitchensjn added the bug Something isn't working label Jun 6, 2023
@kitchensjn kitchensjn added this to the 0.0.2 milestone Nov 17, 2023
@kitchensjn
Copy link
Owner Author

Relating to tskit-dev/tutorials#264 and particularly when y_axis_scale="time" or y_axis_scale="log_time", I think it's better to just have evenly spaced ticks rather than one per node. This will also solve this bug as it'll be more consistent. Maybe by default have evenly spaced ticks and give users the ability to control either the number of ticks or modify the ticks list directly.

kitchensjn added a commit that referenced this issue Mar 10, 2024
@kitchensjn
reworking y axis ticks
562d6f3 
There was often a lot of overlap in tick labels when using `y_axis_scale="time"` or `y_axis_scale="log_time"` as the node timings were so close together. This now limits evenly spaces the tick marks for those scales, while keeping 0 and the max_time. This should avoid the issues mentioned in #8
@kitchensjn
Copy link
Owner Author

Completed with 562d6f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.0.2
Development

No branches or pull requests
1 participant
@kitchensjn