[FUND] Add full support for PHP 8.4 (sub-issue)

[stweil]

Description

PHP 8.4 is the latest stable release and available since November 2024. It is the default version of PHP on macOS with Homebrew and Debian GNU Linux trixie (the next stable version). See https://www.php.net/supported-versions.php.

Expected Benefits of this Development

This task must be done sooner or later.

Estimated Costs and Complexity

The estimated costs and the complexity are low. Kitodo.Presentation seems to work with PHP 8.4 according to the first tests, so maybe only smaller code updates are required.

[markusweigelt]

If we want to support two TYPO3 versions, we need to update to TYPO3 13 first before increasing the PHP version.

TYPO3 11 does not support PHP 8.4: https://get.typo3.org/version/11

It is also part of this issue: #1442 (comment), as the PHP version range will be adjusted anyway. Therefore, I don't see the need to consider this separately.

[stweil]

We can support TYPO3 v12 with PHP 8.4 and still support TYPO3 v11 with PHP 8.3.

Pull request #1505 is an example for the required changes. It is fully compatible with TYPO3 v11 and older PHP versions which we already support. I did not notice any other issues with PHP 8.4, so the only other trivial change which is required is updating the supported version ranges.

[stweil]

It is also part of this issue: #1442 (comment), as the PHP version range will be adjusted anyway.

That's right, so I added it as a sub-issue there. The issue here remains important even without the TYPO3 v13 context because it allows using TYPO3 v12 with the default PHP version on macOS with Homebrew and Debian GNU Linux trixie.

[markusweigelt]

@stweil Can this ticket be closed? Currently, the upper PHP version has been raised to 8.4 in main branch, and PHPStan always checks against the latest PHP version. What else needs to be done here?

[stweil]

At least this is still to be done: #1505 (comment). The related lines are also reported by PHPStan. Up to now I did not notice any other issues with PHP 8.4.

[stweil]

The remaining task is so small that it is not worth discussing it for the development fund. Therefore I removed this classification.

[sebastian-meyer]

We need to explicitly declare nullable function parameters (see #1505):

These code lines need similar fixes:

Classes/Common/DocumentAnnotation.php:    protected function getAudioPagesByFileId($fileId, $range = null)
Classes/Common/DocumentAnnotation.php:    protected function getMeasurePagesByFileId($fileId, $range = null)
Classes/Common/Solr/Solr.php:    public static function getInstance($core = null): Solr
Classes/Common/Solr/SolrSearch.php:    public function __construct(DocumentRepository $documentRepository, $collections, array $settings, array $searchParams, QueryResult $listedMetadata = null, QueryResult $indexedMetadata = null)
Classes/Controller/Backend/NewTenantController.php:    protected function htmlResponse(?string $html = null): ResponseInterface
Classes/Controller/NavigationController.php:    public function pageSelectAction(PageSelectForm $pageSelectForm = null): ResponseInterface
Classes/Controller/PageViewController.php:    public function convertMeasureOrPage($document, $measure = null, $page = null)
Classes/Domain/Repository/DocumentRepository.php:    public function findSolrByCollection(Collection $collection, $settings, $searchParams, $listedMetadata = null, $indexedMetadata = null)
Classes/Domain/Repository/DocumentRepository.php:    public function findSolrByCollections($collections, $settings, $searchParams, $listedMetadata = null, $indexedMetadata = null): SolrSearch
Classes/Domain/Repository/DocumentRepository.php:    public function findSolrWithoutCollection($settings, $searchParams, $listedMetadata = null, $indexedMetadata = null): SolrSearch
Classes/Domain/Repository/DocumentRepository.php:    private function findSolr($collections, $settings, $searchParams, $listedMetadata = null, $indexedMetadata = null): SolrSearch
Classes/Task/BaseAdditionalFieldProvider.php:    protected function getSolrField(int $solr, int $pid = null): array
Classes/Task/BaseAdditionalFieldProvider.php:    private function getSolrCores(int $pid = null): array
Classes/Validation/AbstractDlfValidationStack.php:    protected function addValidator(string $className, string $title, bool $breakOnError = true, array $configuration = null): void

Originally posted by @stweil in #1505 (comment)