diff --git a/Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessFieldedMetadata.java b/Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessFieldedMetadata.java index a427cde1025..0dabe513dc3 100644 --- a/Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessFieldedMetadata.java +++ b/Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessFieldedMetadata.java @@ -444,8 +444,6 @@ private Collection simpleValues(Collection values) { * Returns the only metadata entry or null. Throws an IllegalStateException * if the value is ambiguous or cannot be cast. * - * @param - * * @param values * values obtained * @return the only entry or null diff --git a/Kitodo/src/main/java/org/kitodo/production/interfaces/activemq/MapMessageObjectReader.java b/Kitodo/src/main/java/org/kitodo/production/interfaces/activemq/MapMessageObjectReader.java index c7e128f6772..cc9839613d9 100644 --- a/Kitodo/src/main/java/org/kitodo/production/interfaces/activemq/MapMessageObjectReader.java +++ b/Kitodo/src/main/java/org/kitodo/production/interfaces/activemq/MapMessageObjectReader.java @@ -208,8 +208,6 @@ public Integer getMandatoryInteger(String key) throws JMSException { * type String. */ public Map getMapOfStringToString(String key) { - Map mapOfStringToString = new HashMap<>(); - Object mapObject = null; try { mapObject = ticket.getObject(key); @@ -224,6 +222,8 @@ public Map getMapOfStringToString(String key) { throw new IllegalArgumentException( "Incompatible types: \"" + key + WRONG_TYPE + "Map."); } + + Map mapOfStringToString = new HashMap<>(); for (Object keyObject : ((Map) mapObject).keySet()) { Object valueObject = ((Map) mapObject).get(keyObject); if (!(keyObject instanceof String)) { diff --git a/Kitodo/src/main/java/org/kitodo/production/services/data/TaskService.java b/Kitodo/src/main/java/org/kitodo/production/services/data/TaskService.java index 753b277cdbf..e8a30a2c1e5 100644 --- a/Kitodo/src/main/java/org/kitodo/production/services/data/TaskService.java +++ b/Kitodo/src/main/java/org/kitodo/production/services/data/TaskService.java @@ -120,8 +120,6 @@ public static TaskService getInstance() { */ private BoolQueryBuilder createUserTaskQuery(String filter, boolean onlyOwnTasks, boolean hideCorrectionTasks, boolean showAutomaticTasks, List taskStatusRestrictions) { - User user = ServiceManager.getUserService().getAuthenticatedUser(); - BoolQueryBuilder query = new BoolQueryBuilder(); query.must(getQueryForTemplate(0)); if (Objects.isNull(filter)) { @@ -133,6 +131,8 @@ private BoolQueryBuilder createUserTaskQuery(String filter, boolean onlyOwnTasks query.must(getQueryForProcessingStatuses(taskStatusRestrictions.stream() .map(TaskStatus::getValue).collect(Collectors.toSet()))); + User user = ServiceManager.getUserService().getAuthenticatedUser(); + if (onlyOwnTasks) { query.must(getQueryForProcessingUser(user.getId())); } else { diff --git a/pom.xml b/pom.xml index fab4354720d..3cb96e88db3 100644 --- a/pom.xml +++ b/pom.xml @@ -34,6 +34,7 @@ config/checkstyle.xml ${project.basedir} none + UTF-8 UTF-8 11 @@ -909,12 +910,12 @@ from system library in Java 11+ --> org.apache.maven.plugins maven-checkstyle-plugin - 3.1.2 + 3.4.0 com.puppycrawl.tools checkstyle - 10.3.2 + 10.17.0 @@ -922,7 +923,6 @@ from system library in Java 11+ --> checkstyle-check validate - UTF-8 true false true