Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role list not filtered by client #6261

Open
solth opened this issue Oct 9, 2024 · 3 comments
Open

Role list not filtered by client #6261

solth opened this issue Oct 9, 2024 · 3 comments
Labels
bug user management user, role and permission related topics

Comments

@solth
Copy link
Member

solth commented Oct 9, 2024

Describe the bug
Nearly all lists in Kitodo.Production are filtered by the users currently selected client. Two exceptions are the "Clients" list itself and the "Roles" list on the "Users" page. While it can be argued that the "Clients" list is a justified exception, the "Roles" list should definitely be filtered by client. Instead it is actually sortable by clients, but that is of little use and discloses information that shouldn't be visible to the user in this situation, since there is always a specific client selected in the system that all displayed information should be based upon.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Users" page
  2. Click on tab "Roles"
  3. See error

Expected behavior
The role list should be filtered by client, like all other lists in the system.

@solth solth added the bug label Oct 9, 2024
@henning-gerhardt
Copy link
Collaborator

If role list only visible by current used client it made it more complex to compare roles between clients :-(

@solth
Copy link
Member Author

solth commented Oct 9, 2024

While I do see your point I think hardening (might even say "fixing") our multi client system has to have higher priority.

@henning-gerhardt
Copy link
Collaborator

While I do see your point I think hardening (might even say "fixing") our multi client system has to have higher priority.

I know and we have even a multi client system but with this "fix" there imore work on adjusting the roles after updating to a new version or on need (f.e. security reasons) to change them.

@solth solth added the user management user, role and permission related topics label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug user management user, role and permission related topics
Projects
None yet
Development

No branches or pull requests

2 participants