Catch NPE when unknown metadata and metadata groups are created during import #5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusweigelt
suggested changes
Oct 17, 2022
| return new ProcessFieldedMetadata(structure, divisionView); | ||
| try { | ||
| return new ProcessFieldedMetadata(structure, divisionView); | ||
| } catch (NullPointerException e) { |
There was a problem hiding this comment.
I think when we catch NPE than we should be more direct on the problem e.g. in function ProcessFieldedMetadata.createMetadataEntryEdit. This function should throw ProcessException or a new ProcessFieldException. Otherwise it leads to confusion, misinterpretation or hides other problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR catches the
NullPointerExceptionthat can occur during import that is decribed in #5217 and shows a corresponding error message. It does not fix the underlying issue, but just mitigates the problem.