Setup refreshVersions #811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfayard
commented
May 27, 2021
| @@ -1,7 +1,7 @@ | |||
| dependencies { | |||
| api(project(Fuel.name)) | |||
|
|
|||
| api(KotlinX.Coroutines.jvm) | |||
| api(Kotlinx.Coroutines.jvm) | |||
There was a problem hiding this comment.
this change was needed because the plugin embed two top-level objects with the name AndroidX and KotlinX, that clash with the two same objects defined in the buildSrc
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
============================================
+ Coverage 71.75% 72.80% +1.04%
Complexity 302 302
============================================
Files 61 58 -3
Lines 1519 1489 -30
Branches 216 214 -2
============================================
- Hits 1090 1084 -6
+ Misses 316 295 -21
+ Partials 113 110 -3
Continue to review full report at Codecov.
|
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #810
Description
Set up the project with gradle refreshVersions to make it easier to upgrade dependency versions
Help needed
I had to upgrade to Gradle 6.9
The plugin jacoco-android was incompatible with it, since I'm unfamiliar with it, I couldn't solve the problem easily. Help would be appreciated here.
Also, there is one test failing, and I don't know why, I verified that I didn't change the version of coroutines
Type of change
Check all that apply
How Has This Been Tested?
In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.
Checklist: