Skip to content

Commit 4673282

Browse files
authored
Merge pull request #4405 from kiwix/update_readme_file_for_android_studio_version
Updated the `README` file to reflect the compatible version of Android Studio.
2 parents ef453cc + f8a3396 commit 4673282

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ Kiwix requires the following permissions to fully work:
8080

8181
## Build instructions
8282
1. Clone [this repository](https://github.com/kiwix/kiwix-android).
83-
2. Import the project with [Android Studio Narwhal Canary build](https://developer.android.com/studio/preview).
83+
2. Import the project with [Android Studio](https://developer.android.com/studio).
8484
3. Set the Gradle JDK to Java 17.
8585
4. Run ./gradlew build from the root directory.
8686

core/src/main/java/org/kiwix/kiwixmobile/core/main/reader/CoreReaderFragment.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2232,10 +2232,6 @@ abstract class CoreReaderFragment :
22322232
private fun saveTabStates(onComplete: () -> Unit = {}) {
22332233
CoroutineScope(Dispatchers.Main).launch {
22342234
savingTabsMutex.withLock {
2235-
// clear the previous history saved in database
2236-
withContext(Dispatchers.IO) {
2237-
repositoryActions?.clearWebViewPageHistory()
2238-
}
22392235
val coreApp = sharedPreferenceUtil?.context as CoreApp
22402236
val settings = coreApp.getSharedPreferences(
22412237
SharedPreferenceUtil.PREF_KIWIX_MOBILE,
@@ -2247,6 +2243,9 @@ abstract class CoreReaderFragment :
22472243
getWebViewHistoryEntity(view, index)?.let(webViewHistoryEntityList::add)
22482244
}
22492245
withContext(Dispatchers.IO) {
2246+
// clear the previous history saved in database
2247+
repositoryActions?.clearWebViewPageHistory()
2248+
// Store new history in database.
22502249
repositoryActions?.saveWebViewPageHistory(webViewHistoryEntityList)
22512250
}
22522251
settings.edit {

custom/src/androidTest/java/org/kiwix/kiwixmobile/custom/search/SearchFragmentTestForCustomApp.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,9 @@ class SearchFragmentTestForCustomApp {
299299
clickOnHomeButton(composeTestRule)
300300
// click on an article to load the other page.
301301
clickOnAFoolForYouArticle(composeTestRule)
302+
composeTestRule.mainClock.advanceTimeByFrame()
302303
assertAFoolForYouArticleLoaded(composeTestRule)
304+
composeTestRule.waitUntilTimeout()
303305
// open note screen.
304306
openNoteFragment(customMainActivity as CoreMainActivity, composeTestRule)
305307
composeTestRule.waitUntilTimeout()

0 commit comments

Comments
 (0)