Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduced the "Hotspot Feature" for custom apps. #4223

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #4028

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft February 12, 2025 10:19
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.79%. Comparing base (a88884a) to head (0485691).

Files with missing lines Patch % Lines
...bile/core/webserver/wifi_hotspot/HotspotService.kt 50.00% 0 Missing and 2 partials ⚠️
...iwix/kiwixmobile/di/modules/KiwixActivityModule.kt 0.00% 1 Missing ⚠️
...rg/kiwix/kiwixmobile/core/main/CoreMainActivity.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4223      +/-   ##
============================================
- Coverage     57.18%   56.79%   -0.39%     
- Complexity     1584     1674      +90     
============================================
  Files           316      315       -1     
  Lines         13746    13751       +5     
  Branches       1722     1722              
============================================
- Hits           7860     7810      -50     
- Misses         4692     4766      +74     
+ Partials       1194     1175      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ing the hotspot since we do not required any permission for starting the server in custom apps.

* Fixed: ZIM file was not showing in the Hotspot screen.
* Removed the unnecessary code and creation of demo file for custom app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReIntroduce "Hotspot Feature" for custom apps.
2 participants