Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate LanguageFragment to jetpack. #4160

Open
MohitMaliFtechiz opened this issue Jan 4, 2025 · 7 comments
Open

Migrate LanguageFragment to jetpack. #4160

MohitMaliFtechiz opened this issue Jan 4, 2025 · 7 comments
Assignees
Milestone

Comments

@MohitMaliFtechiz
Copy link
Collaborator

Parent Issue #2669

@kelson42 kelson42 added this to the 3.15.0 milestone Jan 4, 2025
@Uttkarsh08
Copy link

I’d like to take on this issue and migrate the Help Fragment to a Jetpack Compose screen. Kindly assign it to me.

@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented Jan 29, 2025

@Uttkarsh08 What is the update on this issue?

@jackq97
Copy link
Contributor

jackq97 commented Jan 30, 2025

@MohitMaliFtechiz i can work on it. You can assign it to me.

@MohitMaliFtechiz
Copy link
Collaborator Author

@jackq97 Thanks for showing interest, please make a PR when you are done.

@jackq97
Copy link
Contributor

jackq97 commented Feb 10, 2025

@MohitMaliFtechiz Hi , hope you are doing well. I have shifted most of the logic and attached to the composable functions. I'm almost done with List animations still need to fix some kinks in it.
Another challenge I've faced is implementing search text view inside the Top app bar composable.
top app bar seems to support only text view inside the title bar. you can put the edit text inside it but it causes some weird issues like pulling the whole UI down.
I can do some more research on how can i implement it or we can put search bar below the Top app bar. would like to know your view on it

Image
Image

Video of list

Screencast.from.02-10-2025.04.27.40.PM.webm

@MohitMaliFtechiz
Copy link
Collaborator Author

Another challenge I've faced is implementing search text view inside the Top app bar composable.
top app bar seems to support only text view inside the title bar. you can put the edit text inside it but it causes some weird issues like pulling the whole UI down.
I can do some more research on how can i implement it or we can put search bar below the Top app bar. would like to know your view on it

@jackq97 Thanks for the update. The current UI is user friendly and we should make our composable UI like the current UI. So I would suggest to keep the existing UI, giving the search bar below the app bar is not good idea.

@jackq97
Copy link
Contributor

jackq97 commented Feb 11, 2025

@MohitMaliFtechiz sure, I'll look for some workarounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants