Added support for Android's per-app language setting. #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4228 +/- ##
============================================
+ Coverage 57.49% 57.62% +0.13%
- Complexity 1582 1601 +19
============================================
Files 316 316
Lines 13786 13755 -31
Branches 1729 1728 -1
============================================
+ Hits 7926 7927 +1
+ Misses 4669 4650 -19
+ Partials 1191 1178 -13 ☔ View full report in Codecov by Sentry. |
* Introduced the per-app language feature in application. * Added `androidx.appcompat:appcompat-resources` dependency.
…ed language globally so that it is displayed in the system settings.
…t previously selected language will remains active.
…ices. * Since now, `AppCompatDelegate` is handling our local and we don't need to handle it by ourself so we have removed the unused code from our application. * Refactored the test cases to use this new API for handling the locales.
MohitMaliFtechiz
force-pushed
the
Fixes#4222
branch
from
f5b7d99 to
60e3c5c
Compare
…ing the file, and showing the downloading estimate time.
…above devices. * Upgraded the `com.squareup.leakcanary` version to `2.14`.
…dResumeInOtherLanguage` and `verifyHelpActivity` test cases, as it is incorrectly detecting leaks in Android's internal classes.
…istoryDialogTest` test case, as it is incorrectly detecting leaks in Android's internal classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4222
androidx.appcompat:appcompat-resourcesdependency.AppCompatDelegateis handling our locales and we don't need to handle it by ourself so we have removed the unused code from our application.Below Android 13 devices
Per_app_language_android8.mp4
Above Android 15 devices
Per_app_language_android15.mp4