Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an automated Selenium UI test for a small Zimit2 archive #1205

Open
Jaifroid opened this issue Feb 2, 2024 · 5 comments · May be fixed by #1286
Open

Add an automated Selenium UI test for a small Zimit2 archive #1205

Jaifroid opened this issue Feb 2, 2024 · 5 comments · May be fixed by #1286
Assignees
@THEBOSS0369
Labels
tests user interface zimit Code relating to the support of Zimit-style archives
Milestone
v4.3

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Feb 2, 2024

It's probably too soon to do this until we have a fully settled and approved (and published) zimit2 archive. But once we have that, it'd be good to test against one.

Needs to be small enough to be loadable in memory. E.g. 100rabbits.
@Jaifroid Jaifroid added tests user interface zimit Code relating to the support of Zimit-style archives labels Feb 2, 2024
@Jaifroid Jaifroid added this to the v4.1 milestone Feb 2, 2024
@AritraLeo AritraLeo mentioned this issue Mar 14, 2024
Open
@Jaifroid Jaifroid modified the milestones: v4.2, v4.3 Jul 14, 2024
@THEBOSS0369
Copy link
Collaborator

THEBOSS0369 commented Nov 4, 2024 •
edited
Loading

Hey @Jaifroid ! Can you tell me that this issue can be solved now or not like you said

it's probably too soon to do this until we have a fully settled and approved (and published) zimit2 archive

So does the zimit2 archive has crossed all the checks? If yes then i can work on this issue. Also if possible give me some more information like where is the file located or any logic's behind or similar to this so that i can come up with any approach.
Thanks 😁

@Jaifroid
Copy link
Member Author

Jaifroid commented Nov 4, 2024

Ah yes, we do indeed now have officially published zimit2 archives! I would suggest a small but dynamic one such as tonedear.com_en_2024-09.zim. I'm not sure we could test the MIDI audio in Selenium in an automated way, but at least we could check there are no crashes, and things are loading. There are also a couple of small pictures to test (on the Android & iOS Apps page). I like this one because it is functional but is only 2MB in size. Since we have to load ZIMs into memory for testing, we can't test large ones.

@Jaifroid
Copy link
Member Author

Jaifroid commented Nov 4, 2024

@THEBOSS0369 I've assigned you. You need to read TESTS.md (in Repo root) thoroughly, and it will answer your questions about file locations, etc.

@THEBOSS0369
Copy link
Collaborator

Got it Sir! My mistake I didn't look for the test file. I will. Starting working on this issue now .

@THEBOSS0369 THEBOSS0369 linked a pull request Nov 11, 2024 that will close this issue
Open
@THEBOSS0369
Copy link
Collaborator

Hey @Jaifroid ! I have created a PR for this issue #1286 Please take a look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@THEBOSS0369 THEBOSS0369

Labels
tests user interface zimit Code relating to the support of Zimit-style archives
Projects
None yet
Milestone
v4.3
Development

Successfully merging a pull request may close this issue.

Added an automated Selenium UI test for a small Zimit2 archive THEBOSS0369/kiwix-js
2 participants
@Jaifroid @THEBOSS0369