fix: implement Default EVMoutput

success was always false due to its
default value

Author: obatirou

crates/ef-testing/src/evm_sequencer/utils.rs

@@ -155,15 +155,15 @@ pub fn to_broadcasted_starknet_transaction(
 
     // Compute the hash on elements and sign it
     let transaction_hash = compute_hash_on_elements(&data_to_hash);
-    let signature_starknet = RELAYER_SIGNING_KEY
+    let signature_relayer = RELAYER_SIGNING_KEY
         .sign(&transaction_hash)
         .expect("Signature starknet failed");
 
-    let signature_starknet = vec![signature_starknet.r, signature_starknet.s];
+    let signature_relayer = vec![signature_relayer.r, signature_relayer.s];
 
     let request = BroadcastedInvokeTransaction::V1(BroadcastedInvokeTransactionV1 {
         max_fee: Felt::ZERO,
-        signature: signature_starknet,
+        signature: signature_relayer,
         nonce: relayer_nonce,
         sender_address: (*RELAYER_ADDRESS.0.key()).into(),
         calldata: execute_calldata,

crates/ef-testing/src/models/result.rs

@@ -9,7 +9,7 @@ use tracing::{error, info, warn};
 
 use std::convert::TryFrom;
 
-#[derive(Default, Debug)]
+#[derive(Debug)]
 pub struct EVMOutput {
     pub return_data: Vec<u8>,
     pub gas_used: u64,
@@ -24,6 +24,16 @@ impl EVMOutput {
     }
 }
 
+impl Default for EVMOutput {
+    fn default() -> Self {
+        Self {
+            return_data: vec![],
+            gas_used: 0,
+            success: true,
+        }
+    }
+}
+
 impl TryFrom<&EventData> for EVMOutput {
     type Error = eyre::Report;