From 4a78909f7c13cce4e6b416c8325ce83e0a55237b Mon Sep 17 00:00:00 2001 From: Noisy <125606576+donatik27@users.noreply.github.com> Date: Wed, 6 Nov 2024 12:54:40 +0100 Subject: [PATCH 1/5] Update types.md --- docs/contributing/types.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/contributing/types.md b/docs/contributing/types.md index d811f3ab7..46d156e07 100644 --- a/docs/contributing/types.md +++ b/docs/contributing/types.md @@ -2,13 +2,13 @@ ## Hex encoding -Every value is Hex encoded, starts with `0x` and contains at least one +Every value is Hex-encoded, starts with `0x`, and contains at least one hexadecimal digit - ✅ 0x1 - ✅ 0x01 - ✅ 0x0 -- ❌ 0x +- ❌ 0x // Invalid, missing hexadecimal digits - ❌ 0x4000 // no leading zeroes allowed - ❌ ff // must be prefixed with `0x` From 15fe0d1d11fdc8885e3a96003e371b39e39564eb Mon Sep 17 00:00:00 2001 From: Noisy <125606576+donatik27@users.noreply.github.com> Date: Mon, 11 Nov 2024 14:04:09 +0100 Subject: [PATCH 2/5] Update eth_call.md --- docs/methods/eth_call.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/methods/eth_call.md b/docs/methods/eth_call.md index c7c528039..a275fb6bd 100644 --- a/docs/methods/eth_call.md +++ b/docs/methods/eth_call.md @@ -9,7 +9,7 @@ ## Description -Submits an EVM call by wrapping the EVM compatible transaction object into a +Submits an EVM call by wrapping the EVM-compatible transaction object into a Starknet call. Kakarot Specificity: From 6855b8556fb696b615ef4b219d17e1846591a444 Mon Sep 17 00:00:00 2001 From: Noisy <125606576+donatik27@users.noreply.github.com> Date: Mon, 11 Nov 2024 14:06:08 +0100 Subject: [PATCH 3/5] Update eth_coinbase.md --- docs/methods/eth_coinbase.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/methods/eth_coinbase.md b/docs/methods/eth_coinbase.md index 3f797f21b..85950f55c 100644 --- a/docs/methods/eth_coinbase.md +++ b/docs/methods/eth_coinbase.md @@ -11,6 +11,6 @@ Returns the Ethereum account controlled by the Kakarot zkEVM sequencer. -Kakarot specifity: since Kakarot set of Cairo programs run on the StarknetOS +Kakarot specificity: since Kakarot set of Cairo programs run on the StarknetOS (i.e. on an underlying CairoVM client), the coinbase is the EVM representation of a Starknet account that collects the fees. From 9ae6f53124ab59fe478734f8767ae8dd58f23b7d Mon Sep 17 00:00:00 2001 From: Noisy <125606576+donatik27@users.noreply.github.com> Date: Mon, 11 Nov 2024 14:08:23 +0100 Subject: [PATCH 4/5] Update eth_estimateGas.md --- docs/methods/eth_estimateGas.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/methods/eth_estimateGas.md b/docs/methods/eth_estimateGas.md index 3b348bb11..f22a47b53 100644 --- a/docs/methods/eth_estimateGas.md +++ b/docs/methods/eth_estimateGas.md @@ -15,5 +15,5 @@ transaction to complete. Kakarot Specificity: - Call the Kakarot Cairo smart contract's entrypoint: `eth_call` with the EVM - transaction fields as argument and get the returned `gas_used` variable. This + transaction fields as arguments and get the returned `gas_used` variable. This value is the estimated gas needed to complete the transaction. From 708060f77cd91e09a146ee60a096a00c133e7fcf Mon Sep 17 00:00:00 2001 From: Noisy <125606576+donatik27@users.noreply.github.com> Date: Mon, 11 Nov 2024 14:11:50 +0100 Subject: [PATCH 5/5] Update eth_gasPrice.md --- docs/methods/eth_gasPrice.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/methods/eth_gasPrice.md b/docs/methods/eth_gasPrice.md index e7082ff20..84e78ae04 100644 --- a/docs/methods/eth_gasPrice.md +++ b/docs/methods/eth_gasPrice.md @@ -11,7 +11,7 @@ Returns the current price per gas in wei. -Kakarot specifity: since Kakarot does not have a fee market as of January 2024, +Kakarot specificity: since Kakarot does not have a fee market as of January 2024, transactions are ordered on a "First Come First Serve" basis. For this reason: