Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kkrt-labs/kakarot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a15f20985039502300649424e5a7726b181bc0ee
Choose a base ref
...
head repository: kkrt-labs/kakarot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 76a16ca10f43aafec65f1e85b8dbab8859d641a9
Choose a head ref
  • 2 commits
  • 23 files changed
  • 2 contributors

Commits on Feb 5, 2024

  1. fix: deployed precompiles (#947)

    <!--- Please provide a general summary of your changes in the title
    above -->
    
    <!-- Give an estimate of the time you spent on this PR in terms of work
    days.
    Did you spend 0.5 days on this PR or rather 2 days?  -->
    
    Time spent on this PR: 0.1
    
    ## Pull request type
    
    <!-- Please try to limit your pull request to one type,
    submit multiple pull requests if needed. -->
    
    Please check the type of change your PR introduces:
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, renaming)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] Documentation content changes
    - [ ] Other (please describe):
    
    ## What is the current behavior?
    
    <!-- Please describe the current behavior that you are modifying,
    or link to a relevant issue. -->
    
    Resolves #946
    
    ## What is the new behavior?
    
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - Prevent precompiles from being deployed. It was not an issue before
    they were cached in the warm accounts.
    -
    -
    
    <!-- Reviewable:start -->
    - - -
    This change is [<img src="https://reviewable.io/review_button.svg"
    height="34" align="absmiddle"
    alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/947)
    <!-- Reviewable:end -->
    enitrat authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a35cfe9 View commit details
    Browse the repository at this point in the history
  2. Add coinbase, base fee and effective gas price (#944)

    Time spent on this PR: 0.6
    
    ## Pull request type
    
    Please check the type of change your PR introduces:
    
    - [ ] Bugfix
    - [x] Feature
    - [ ] Code style update (formatting, renaming)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] Documentation content changes
    - [ ] Other (please describe):
    
    ## What is the current behavior?
    
    For EIP1559 txs, we don't compute the effective gas price but just
    propagate the max_fee_per_gas.
    The block base fee is not set, which means it's like 0.
    
    Resolves #929 #869
    
    ## What is the new behavior?
    
    - Split the logic of tx decoding to have one function per tx type
    - compute the effective gas price in EOA.execute based on the Kakarot
    base fee
    - introduced a new model.EthTransaction for a normalized tx type, and
    serde
    - added coinbase and base_fee storage vars to kakarot
    
    <!-- Reviewable:start -->
    - - -
    This change is [<img src="https://reviewable.io/review_button.svg"
    height="34" align="absmiddle"
    alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/944)
    <!-- Reviewable:end -->
    ClementWalter authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    76a16ca View commit details
    Browse the repository at this point in the history
Loading