Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selfdestruct should not "send to a burn address", but _really_ burn tokens #241

Open
enitrat opened this issue Dec 10, 2024 · 0 comments

Comments

@enitrat
Copy link
Collaborator

enitrat commented Dec 10, 2024

The fix implemented in https://github.com/kkrt-labs/keth/pull/235/files is relative to the C4 audit of the Kakarot Codebase. As we're not bounded to a Starknet environment with Keth, we should not be sending eth to a "burn address" (which will make any EVM tx unprovable due to a wrong state update) but rather simply delete the balance of the sender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants