feat(validtor-bot): review fixes

Author: madhurMongia

validator-cli/src/ArbToEth/watcherArbToGnosis.ts

@@ -212,12 +212,15 @@ const watch = async () => {
 
     const veaEpochOutboxClaimableNowOld = veaEpochOutboxClaimableNow;
     veaEpochOutboxClaimableNow = Math.floor(timeGnosis / epochPeriod) - 1;
-    // TODO: sometimes veaEpochOutboxClaimableNow is 1 epoch behind veaEpochOutboxClaimableNowOld
-    const veaEpochsOutboxClaimableNew: number[] = new Array(veaEpochOutboxClaimableNow - veaEpochOutboxClaimableNowOld)
-      .fill(veaEpochOutboxClaimableNowOld + 1)
-      .map((el, i) => el + i);
 
-    veaEpochOutboxCheckClaimsRangeArray.concat(veaEpochsOutboxClaimableNew);
+    if (veaEpochOutboxClaimableNow > veaEpochOutboxClaimableNowOld) {
+      const veaEpochsOutboxClaimableNew: number[] = new Array(
+        veaEpochOutboxClaimableNow - veaEpochOutboxClaimableNowOld
+      )
+        .fill(veaEpochOutboxClaimableNowOld + 1)
+        .map((el, i) => el + i);
+      veaEpochOutboxCheckClaimsRangeArray.push(...veaEpochsOutboxClaimableNew);
+    }
 
     if (veaEpochOutboxCheckClaimsRangeArray.length == 0) {
       console.log("no claims to check");
@@ -248,7 +251,7 @@ const watch = async () => {
           );
           veaEpochOutboxCheckClaimsRangeArray.splice(index, 1);
           index--;
-          if (challenges.has(index)) challenges.delete(index);
+          if (challenges.has(veaEpochOutboxCheck)) challenges.delete(veaEpochOutboxCheck);
           continue;
         } else {
           console.log(
@@ -320,7 +323,7 @@ const watch = async () => {
             continue;
           }
           console.log(veaEpochOutboxCheck, "claim found ", { claim });
-          const previousProgress = challenges.get(index) || ({} as any);
+          const previousProgress = challenges.get(veaEpochOutboxCheck) || ({} as any);
           let challengeProgress = await reconstructChallengeProgress(
             veaEpochOutboxCheck,
             veaOutbox,
@@ -333,7 +336,7 @@ const watch = async () => {
             amb,
             previousProgress
           );
-          challenges.set(index, challengeProgress);
+          challenges.set(veaEpochOutboxCheck, challengeProgress);
           console.log(
             "challenge progess for epoch " + veaEpochOutboxCheck + "  is " + JSON.stringify(challengeProgress)
           );
@@ -389,7 +392,7 @@ const watch = async () => {
                   finalized: false,
                 };
                 challengeProgress.status = "WithdrawalPending";
-                challenges.set(index, challengeProgress);
+                challenges.set(veaEpochOutboxCheck, challengeProgress);
               }
             }
           }