relase: get failed extract-vmlinux automation back working

Only the command is back in business, but it does not work:
cirosantilli#79

Author: cirosantilli

Diff for: README.adoc

@@ -553,7 +553,7 @@ Which components to build. Default: qemu-buildroot
             else:
                 git_version_tuple = tuple(
                     int(x) for x in self.sh.check_output(['git', '--version']) \
-                    .split(' ')[-1].split('.')
+                    .decode().split(' ')[-1].split('.')
                 )
                 if git_version_tuple >= (2, 9, 0):
                     # https://stackoverflow.com/questions/26957237/how-to-make-git-clone-faster-with-multiple-threads/52327638#52327638

Diff for: build

@@ -50,7 +50,7 @@ from the README to example sources to GitHub rather than locally.
         for link in self.sh.check_output([
             os.path.join(asciidoctor_dir, 'extract-link-targets'),
             self.env['readme']
-        ]).splitlines():
+        ]).decode().splitlines():
             if not external_link_re.match(link):
                 if not os.path.lexists(os.path.join(self.env['root_dir'], link)):
                     self.log_error('broken link to local file: ' + link)
@@ -63,7 +63,7 @@ from the README to example sources to GitHub rather than locally.
         for header_id in self.sh.check_output([
             os.path.join(asciidoctor_dir, 'extract-header-ids'),
             self.env['readme']
-        ]).splitlines():
+        ]).decode().splitlines():
             header_ids.add(header_id)
         for grep_line in self.sh.check_output(
             [
@@ -74,7 +74,7 @@ from the README to example sources to GitHub rather than locally.
                 LF
             ],
             cwd=self.env['root_dir']
-        ).splitlines():
+        ).decode().splitlines():
             url_index = grep_line.index(self.env['homepage_url'])
             hash_start_index = url_index + len(self.env['homepage_url'])
             if len(grep_line) > hash_start_index:

Diff for: build-doc

@@ -1090,7 +1090,7 @@ def get_elf_entry(self, elf_file_path):
             self.get_toolchain_tool('readelf'),
             '-h',
             elf_file_path
-        ])
+        ]).decode()
         for line in readelf_header.decode().split('\n'):
             split = line.split()
             if line.startswith('  Entry point address:'):

Diff for: common.py

@@ -23,7 +23,7 @@ https://cirosantilli.com/linux-kernel-module-cheat#release-upload
             'describe',
             '--exact-match',
             '--tags'
-        ]).rstrip()
+        ]).decode().rstrip()
         upload_path = self.env['release_zip_file']
 
         # Check the release already exists.

Diff for: release-upload

@@ -415,8 +415,18 @@ Extra options to append at the end of the emulator command line.
                     self.env['baremetal'] is None and
                     self.env['userland'] is None
                 ):
-                    # This is to run gem5 from a prebuilt download.
-                    self.sh.run_cmd([self.env['extract_vmlinux'], self.env['linux_image']])
+                    # This is an attempte to run gem5 from a prebuilt download
+                    # but it is not working:
+                    # https://github.com/cirosantilli/linux-kernel-module-cheat/issues/79
+                    self.sh.check_output(
+                        [
+                            self.env['extract_vmlinux'],
+                            self.env['linux_image']
+                        ],
+                        out_file=self.env['image'],
+                        show_cmd=True,
+                        show_stdout=False
+                    )
                 else:
                     raise_image_not_found()
             else:

Diff for: run

@@ -78,13 +78,20 @@ def base64_decode(self, string):
         return base64.b64decode(string.encode()).decode()
 
     def check_output(self, *args, **kwargs):
+        '''
+        Analogous to subprocess.check_output: get the stdout / stderr
+        of a program back as a byte array.
+        '''
         out_str = []
+        actual_kwargs = {
+            'show_stdout': False,
+            'show_cmd': False
+        }
+        actual_kwargs.update(kwargs)
         self.run_cmd(
             *args,
             out_str=out_str,
-            show_stdout=False,
-            show_cmd=False,
-            **kwargs
+            **actual_kwargs
         )
         return out_str[0]
 
@@ -380,7 +387,7 @@ def run_cmd(
                     if out_file is not None:
                         logfile.close()
                     if out_str is not None:
-                        out_str.append((b''.join(logfile_str)).decode())
+                        out_str.append((b''.join(logfile_str)))
             if threading.current_thread() == threading.main_thread():
                 signal.signal(signal.SIGINT, sigint_old)
                 #signal.signal(signal.SIGPIPE, sigpipe_old)
@@ -392,7 +399,7 @@ def run_cmd(
             return returncode
         else:
             if not out_str is None:
-                out_str.append('')
+                out_str.append(b'')
             return 0
 
     def shlex_split(self, string):