Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #2 #3

Closed
wants to merge 2 commits into from
Closed

Fix issue #2 #3

wants to merge 2 commits into from

Conversation

Mesfrum
Copy link

@Mesfrum Mesfrum commented Feb 24, 2024

Fixes #2

Changes Made:

  • Changed contents of span [id: floatype-caret] with a [caret] placeholder.
  • Updated floatype.min.js to reflect the above change.

307548639-fbb55473-6565-4d87-ae16-5b3a487a5162

@knadh
Copy link
Owner

knadh commented Jul 12, 2024

Hi @Mesfrum. Can you host a static page of your implementation so that I could test it?

@non-engineer-dev non-engineer-dev mentioned this pull request Aug 25, 2024
Merged
@non-engineer-dev
Copy link
Contributor

@knadh @Mesfrum
Here's the hosted link for this PR: https://66cb03ba361cdfeb5ae6afd7--splendid-muffin-059e1b.netlify.app/
Please also refer to this PR before merging because this PR unnecessarily adds text [caret] in the placeholder.

@knadh
Copy link
Owner

knadh commented Aug 26, 2024

Fixed in #7.

@knadh knadh closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion is always at the end of the text
3 participants
@Mesfrum @knadh @non-engineer-dev