Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Change KafkaChannel defaults for partition and replica #1006

Open
matzew opened this issue Nov 30, 2021 · 8 comments · Fixed by #1085
Open

Change KafkaChannel defaults for partition and replica #1006

matzew opened this issue Nov 30, 2021 · 8 comments · Fixed by #1085
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Issues which should be fixed (post-triage)

Comments

@matzew
Copy link
Contributor

matzew commented Nov 30, 2021

Problem
The current defaults for setting partitions and replica to 1 is a pretty poor choice.

We noticed in tests that it is much much better if we default to something like 10 partitions and 3 replica

The issue here is that 3 replica does not work single broker instances, but those are generally considered being a toy.

For POCs or demos, the replica can be still configured to be 1, on the actual KafkaChannel object - so single broker usage is still possible

Persona:
Which persona is this feature for?

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

@pierDipi
Copy link
Member

I can bring this in today's Kafka WG call if you won't join.

@pierDipi pierDipi added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Nov 30, 2021
@aliok
Copy link
Member

aliok commented Nov 30, 2021

I don't have a strong opinion.

  • Defaults that are good for getting started: prod users should set the config
  • Defaults that are better for prod: getting-started-users should set the config

I think I would still prefer option 1, but I am ok with it both

@travis-minke-sap
Copy link
Contributor

I'm ok either way ; )
(fwiw - we set them in all KafkaChannel instances for our production use cases)

@matzew
Copy link
Contributor Author

matzew commented Feb 7, 2022

FWIW, we have the same defaults on the knative kafka broker

@pierDipi
Copy link
Member

/reopen

@knative-prow-robot
Copy link
Contributor

@pierDipi: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2022
@pierDipi
Copy link
Member

/remove-lifecycle stale
/triage accepted

@knative-prow knative-prow bot added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants