Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

[QE] Setting KafkaChannel as default by config map should have an option to set via operator #702

Open
cardil opened this issue Jun 10, 2021 · 6 comments
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@cardil
Copy link
Contributor

cardil commented Jun 10, 2021

It would be a good idea to have this code, capable to override the way the config map is applied. Currently, it's applying it directly, but when running under operator, that gets overwritten.

https://github.com/knative-sandbox/eventing-kafka/blob/f95e2c1c5fa237cef1389e8e64a53dbf93444979/test/upgrade/continual/channel.go#L244-L275

This prevented us to remove static configuration of default channel we have in https://github.com/openshift-knative/serverless-operator/blob/0b59eed02ce03ad382807af565fab33484a42e8d/hack/lib/serverless.bash#L219-L244 while running those tests in openshift-knative/serverless-operator#983 and openshift-knative/serverless-operator#1011. That's unfortunate as we can't test IMC in that way.

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2021
@cardil
Copy link
Contributor Author

cardil commented Sep 30, 2021

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2021
@pierDipi
Copy link
Member

pierDipi commented Jan 3, 2022

/remove-lifecycle stale
/triage accepted

@knative-prow-robot knative-prow-robot added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 3, 2022
@pierDipi
Copy link
Member

pierDipi commented Jan 3, 2022

/area test-and-release

@knative-prow-robot
Copy link
Contributor

@pierDipi: The label(s) area/test-and-release cannot be applied, because the repository doesn't have them.

In response to this:

/area test-and-release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

3 participants