-
Notifications
You must be signed in to change notification settings - Fork 83
[QE] Setting KafkaChannel as default by config map should have an option to set via operator #702
Comments
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
/area test-and-release |
@pierDipi: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It would be a good idea to have this code, capable to override the way the config map is applied. Currently, it's applying it directly, but when running under operator, that gets overwritten.
https://github.com/knative-sandbox/eventing-kafka/blob/f95e2c1c5fa237cef1389e8e64a53dbf93444979/test/upgrade/continual/channel.go#L244-L275
This prevented us to remove static configuration of default channel we have in https://github.com/openshift-knative/serverless-operator/blob/0b59eed02ce03ad382807af565fab33484a42e8d/hack/lib/serverless.bash#L219-L244 while running those tests in openshift-knative/serverless-operator#983 and openshift-knative/serverless-operator#1011. That's unfortunate as we can't test IMC in that way.
The text was updated successfully, but these errors were encountered: