Fix metrics config setup for source controller

[aavarghese]

{"severity":"ERROR","timestamp":"2021-01-27T17:31:31.7621829Z","logger":"redis-stream-source","caller":"metrics/exporter.go:148","message":"Failed to get a valid metrics config","error":"metrics domain cannot be empty","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"knative.dev/[email protected]/metrics/exporter.go","line":"148","function":"knative.dev/pkg/metrics.UpdateExporter"},"stacktrace":"knative.dev/pkg/metrics.UpdateExporter\n\tknative.dev/[email protected]/metrics/exporter.go:148\nknative.dev/eventing/pkg/adapter/v2.MainWithInformers\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:131\nknative.dev/eventing/pkg/adapter/v2.MainWithEnv\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:105\nknative.dev/eventing/pkg/adapter/v2.MainWithContext\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:80\nknative.dev/eventing/pkg/adapter/v2.Main\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:76\nmain.main\n\tknative.dev/eventing-redis/source/cmd/receive_adapter/main.go:26\nruntime.main\n\truntime/proc.go:204"}
{"severity":"ERROR","timestamp":"2021-01-27T17:31:31.7622881Z","logger":"redis-stream-source","caller":"v2/main.go:132","message":"failed to create the metrics exporter{error 26 0  metrics domain cannot be empty}","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"knative.dev/[email protected]/pkg/adapter/v2/main.go","line":"132","function":"knative.dev/eventing/pkg/adapter/v2.MainWithInformers"},"stacktrace":"knative.dev/eventing/pkg/adapter/v2.MainWithInformers\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:132\nknative.dev/eventing/pkg/adapter/v2.MainWithEnv\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:105\nknative.dev/eventing/pkg/adapter/v2.MainWithContext\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:80\nknative.dev/eventing/pkg/adapter/v2.Main\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:76\nmain.main\n\tknative.dev/eventing-redis/source/cmd/receive_adapter/main.go:26\nruntime.main\n\truntime/proc.go:204"}

Install source, and an instance of redis stream source. These error message appears in the logs.
Reference: #68 (comment)

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[aavarghese]

/remove-lifecycle stale

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[aavarghese]

/remove-lifecycle stale

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[aavarghese]

/reopen

[knative-prow-robot]

@aavarghese: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mericano1]

I am having the same issue. Has anyone solved it ? Not sure if that is the reason the pod redissource-mystream-1234 doesn't start. Here is the logs

{"severity":"ERROR","timestamp":"2022-02-05T18:04:07.811802Z","logger":"redis-stream-source","caller":"v2/main.go:132","message":"Failed to create the metrics exporter","error":"metrics domain cannot be empty","stacktrace":"knative.dev/eventing/pkg/adapter/v2.MainWithInformers\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:132\nknative.dev/eventing/pkg/adapter/v2.MainWithEnv\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:105\nknative.dev/eventing/pkg/adapter/v2.MainWithContext\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:80\nknative.dev/eventing/pkg/adapter/v2.Main\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:76\nmain.main\n\tknative.dev/eventing-redis/source/cmd/receive_adapter/main.go:26\nruntime.main\n\truntime/proc.go:225"}
{"severity":"WARNING","timestamp":"2022-02-05T18:04:07.8118593Z","logger":"redis-stream-source","caller":"v2/config.go:185","message":"Tracing configuration is invalid, using the no-op default{error 26 0  empty json tracing config}"}
{"severity":"WARNING","timestamp":"2022-02-05T18:04:07.8119215Z","logger":"redis-stream-source","caller":"v2/config.go:178","message":"Sink timeout configuration is invalid, default to -1 (no timeout)"}
panic: nil

goroutine 1 [running]:
knative.dev/eventing-redis/source/pkg/adapter.(*Adapter).newPool.func1(0xc0007104e0, 0xc00003c058, 0x43, 0xc0007860a0)
	knative.dev/eventing-redis/source/pkg/adapter/adapter.go:244 +0x466
knative.dev/eventing-redis/source/pkg/adapter.(*Adapter).Start(0xc0007104e0, 0x1e16eb8, 0xc000521e60, 0x0, 0x0)
	knative.dev/eventing-redis/source/pkg/adapter/adapter.go:76 +0x93
knative.dev/eventing/pkg/adapter/v2.MainWithInformers(0x1e16eb8, 0xc000521e60, 0x1be1e8e, 0x13, 0x1e2c140, 0xc000738900, 0x1c93fe0)
	knative.dev/[email protected]/pkg/adapter/v2/main.go:204 +0x1007
knative.dev/eventing/pkg/adapter/v2.MainWithEnv(0x1e177e8, 0xc0007141f0, 0x1be1e8e, 0x13, 0x1e2c140, 0xc000738900, 0x1c93fe0)
	knative.dev/[email protected]/pkg/adapter/v2/main.go:105 +0x22d
knative.dev/eventing/pkg/adapter/v2.MainWithContext(0x1e177e8, 0xc0007141f0, 0x1be1e8e, 0x13, 0x1c93fe8, 0x1c93fe0)
	knative.dev/[email protected]/pkg/adapter/v2/main.go:80 +0x75
knative.dev/eventing/pkg/adapter/v2.Main(0x1be1e8e, 0x13, 0x1c93fe8, 0x1c93fe0)
	knative.dev/[email protected]/pkg/adapter/v2/main.go:76 +0x98
main.main()
	knative.dev/eventing-redis/source/cmd/receive_adapter/main.go:26 +0x4e

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[pierDipi]

/triage accepted

[pierDipi]

/remove-lifecycle stale