Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example app [React.js] for Parcel build #18

Open
4 tasks
ashokdey opened this issue Oct 8, 2019 · 5 comments
Open
4 tasks

Add example app [React.js] for Parcel build #18

ashokdey opened this issue Oct 8, 2019 · 5 comments
Assignees
Labels
beginner friendly enhancement New feature or request good first issue Good for newcomers Hacktoberfest Start your open source journey this October

Comments

@ashokdey
Copy link
Member

ashokdey commented Oct 8, 2019

Hey folks, you will notice that this repo contains 3 branches:

  • master
  • parcel
  • webpack-4

What is required?

  • Remove the old app
  • Add new sample app (must contain an API call)
  • Use the latest version of react and react hooks
  • Update the README for the branch

Notes:

  • Your PR should point to the parcel branch
  • Your PR should contain screenshots of the working app you added
  • Add a star if you like the work and this will motivate the project owners to do more
@ashokdey ashokdey added enhancement New feature or request good first issue Good for newcomers Hacktoberfest Start your open source journey this October beginner friendly labels Oct 8, 2019
@ashokdey ashokdey changed the title Add example app for Parcel build Add example app [React.js] for Parcel build Oct 8, 2019
@souravdasslg
Copy link

souravdasslg commented Oct 8, 2019

Hey @ashokdey, I'd love to contribute. For clarification, do I need to create the sample app myself?

@ashokdey
Copy link
Member Author

ashokdey commented Oct 8, 2019

Hello @souravdasslg, thanks for taking an interest, well yes. You have to create a new small app that must contain API integration.

I have assigned you the task, you are good to go.

@souravdasslg
Copy link

souravdasslg commented Oct 8, 2019

Hey @ashokdey , I'm considering removing the entire configuration and previous codes for the sample app. Planning to start it from scratch. I'd love to have your opinion on this.

@ashokdey
Copy link
Member Author

ashokdey commented Oct 8, 2019

I want to know what all things you want to remove? Please list down the things.

@souravdasslg
Copy link

Sure thing.I'm considering creating the sample app through CRA, as this issue requires to create an app with the latest react version.
These are my steps

  1. Remove the entire old code base and create a new app.
  2. Configure eslint and babel as per the previous configuration.
  3. Add and configure the custom scripts.
  4. Configure parcel build with the latest configuration using the same command created in the package.json

Please let me know if any changes are required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner friendly enhancement New feature or request good first issue Good for newcomers Hacktoberfest Start your open source journey this October
Projects
None yet
Development

No branches or pull requests

2 participants