From 68401517ccc3d52710f7fa6de76b0d96d491e1fa Mon Sep 17 00:00:00 2001 From: Saurabh Kumar Bajpai Date: Sun, 2 Aug 2026 20:18:33 +0530 Subject: [PATCH] fix: code quality and safety improvements --- src/app/(routes)/rooms/[id]/members/page.tsx | 2 +- src/app/api/classrooms/[id]/export/route.ts | 4 ++-- src/app/api/confusion/route.ts | 2 +- src/app/api/doubts/[id]/route.ts | 2 +- src/app/api/replies/action/[id]/route.ts | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/app/(routes)/rooms/[id]/members/page.tsx b/src/app/(routes)/rooms/[id]/members/page.tsx index 424d2102..8af26dbd 100644 --- a/src/app/(routes)/rooms/[id]/members/page.tsx +++ b/src/app/(routes)/rooms/[id]/members/page.tsx @@ -59,7 +59,7 @@ function RoleBadge({ role, isOwner }: { role: string; isOwner: boolean }) { function formatJoinedAt(joinedAt: string): string { const date = new Date(joinedAt); - if (isNaN(date.getTime())) return ''; + if (Number.isNaN(date.getTime())) return ''; return date.toLocaleDateString(undefined, { year: 'numeric', month: 'short', day: 'numeric' }); } diff --git a/src/app/api/classrooms/[id]/export/route.ts b/src/app/api/classrooms/[id]/export/route.ts index c22ad002..957e1e16 100644 --- a/src/app/api/classrooms/[id]/export/route.ts +++ b/src/app/api/classrooms/[id]/export/route.ts @@ -47,14 +47,14 @@ export async function GET( if (from) { const fromDate = new Date(from); - if (!isNaN(fromDate.getTime())) { + if (!Number.isNaN(fromDate.getTime())) { conditions.push(gte(doubtsTable.createdAt, fromDate)); } } if (to) { const toDate = new Date(to); - if (!isNaN(toDate.getTime())) { + if (!Number.isNaN(toDate.getTime())) { conditions.push(lte(doubtsTable.createdAt, toDate)); } } diff --git a/src/app/api/confusion/route.ts b/src/app/api/confusion/route.ts index 0c3a613c..972782ac 100644 --- a/src/app/api/confusion/route.ts +++ b/src/app/api/confusion/route.ts @@ -56,7 +56,7 @@ export async function PATCH(req: Request) { } const targetId = Number(alertIdString); - if (isNaN(targetId)) { + if (Number.isNaN(targetId)) { return new NextResponse("Invalid alert id", { status: 400 }); } diff --git a/src/app/api/doubts/[id]/route.ts b/src/app/api/doubts/[id]/route.ts index 20c89233..bfe9805d 100644 --- a/src/app/api/doubts/[id]/route.ts +++ b/src/app/api/doubts/[id]/route.ts @@ -14,7 +14,7 @@ export async function GET( const { id } = await params; const doubtId = parseInt(id, 10); - if (isNaN(doubtId)) { + if (Number.isNaN(doubtId)) { return NextResponse.json({ error: "Invalid doubt ID" }, { status: 400 }); } diff --git a/src/app/api/replies/action/[id]/route.ts b/src/app/api/replies/action/[id]/route.ts index 109c22ab..b3df94e2 100644 --- a/src/app/api/replies/action/[id]/route.ts +++ b/src/app/api/replies/action/[id]/route.ts @@ -33,7 +33,7 @@ export async function PATCH(req: NextRequest, { params }: { params: Promise<{ id const { id } = await params; const parsedReplyId = parseInt(id); - if (isNaN(parsedReplyId)) { + if (Number.isNaN(parsedReplyId)) { return NextResponse.json({ error: "Invalid reply ID" }, { status: 400 }); } @@ -121,7 +121,7 @@ export async function DELETE(req: NextRequest, { params }: { params: Promise<{ i const { id } = await params; const replyId = parseInt(id); - if (isNaN(replyId)) { + if (Number.isNaN(replyId)) { return NextResponse.json({ error: "Invalid reply ID" }, { status: 400 }); }