Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package spatie/data-transfer-object is abandoned, switch to spatie/laravel-data #589

Closed
mariovillani opened this issue Dec 16, 2022 · 9 comments
Labels
question Further information is requested

Comments

@mariovillani
Copy link

Hello,
i get the following warning when installing the package via composer:

Package spatie/data-transfer-object is abandoned, you should avoid using it. Use spatie/laravel-data instead.

Is it hard to switch to the new package?
Doing a quick code research, i see that impacted classes are in /camel folder:

BaseDTO.php
BaseDTOCollection.php`

Thanks in advance!

@mariovillani mariovillani added the question Further information is requested label Dec 16, 2022
@repat
Copy link

repat commented Dec 19, 2022

@mariovillani See #546 (comment). When looking for issue, make sure to include closed ones ;)

I'm currently looking into replacing spatie/data-transfer-object with spatie/laravel-data and creating a PR, as @shalvah said "sure, give it a shot". I'll let you know what I find.

@bram-pkg
Copy link
Contributor

@repat how's that going? :)

@shalvah shalvah pinned this issue Mar 4, 2023
@shalvah shalvah closed this as completed Mar 4, 2023
@tomcoonen
Copy link

@shalvah You closed this issue but the dependency is not replaced? Anything we can do to help?

@shalvah
Copy link
Contributor

shalvah commented Mar 21, 2023

Dudeeee...did you not see my response, which has already been linked to (and quoted) in this thread? My answer has not changed.

Guys, if you want the package replaced, then you'll have to do the work. I have too many other things going on in my life to spend hours figuring out how to migrate to a package that has zero benefit for me OR this package. Ffs, the ONLY benefit to you as a user is to make your console a little less noisy. That's hours of unpaid, unfulfilling work. What gives?

I already spend enough (unpaid) time addressing issues from users every week, and working on the actual functionality of this package. Would you prefer I spend my limited time on this? Fuck, even if you sent in a PR, I'd still have to do the work of double-checking it.

In conclusion: this is the lowest of all low priorities imaginable. Heck, it's not even a priority. Even if you sent a PR, I can't guarantee I'd merge it in any time, because it's still work for me (reviewing and maintaining afterwards). So please don't ask me about this again.

@tomcoonen
Copy link

Thanks for the response, I somehow did not see the comment or interpreted it correctly since the issue was closed.
I agree with you, just seeing if we can help to get it replaced..

@repat Did you make any progress?

@shalvah
Copy link
Contributor

shalvah commented Mar 21, 2023

Good, thank you for understanding. Closed the issue because when I look at open issues, I want to see things that need my attention. Muting it as well. Adios.👋

@repat
Copy link

repat commented Mar 23, 2023

Thanks for the response, I somehow did not see the comment or interpreted it correctly since the issue was closed. I agree with you, just seeing if we can help to get it replaced..

@repat Did you make any progress?

@tomcoonen sry I just didn't have the time yet

@jhoanborges
Copy link

+1

@codespearhead
Copy link

codespearhead commented Jul 4, 2024

@jhoanborges Are you willing to submit a PR?

Because I currently don't have time to tackle it myself, but I can help if you get stuck.

Friendly reminder that open-source projects rely heavily on the community to stay viable, and by that I'm not necessarily mean financial contributions only: triaging issues and submitting patches, which tend to be time-consuming, go a long way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

7 participants