This repository has been archived by the owner on Aug 18, 2023. It is now read-only.
Remove shared preferences as a hard dependency #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aches Removed mocking of this cache in the tests TODO: extract shared preferences cache into its own package or put it in the README how to use it
|
Really sorry, but we are no longer maintaining the repository. We will archive it shortly |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robertohuertasm I haven't been able to run the tests because I couldn't generate the mocks, but thought I'd submit a draft PR on how I might propose the change.
I haven't dropped share_preferences as a dependency, but for now I've introduced a
StringCacheabstraction that defaults to in-memory. I've also implemented aSharedPreferencesStringCacheto show how we could still useSharedPreferencesif we want to.I'm not sure if we'd want to:
One advantage is that we no longer need to mock SharedPreferences for the tests. The default in-memory cache will run with no problem.
Meant to resolve #29