Improve typing

Author: vixducis

src/Informat/AccessToken/AccessTokenFetcher.php

@@ -39,7 +39,10 @@ public function fetch(): AccessToken
 
         $response = $this->httpClient->sendRequest($request);
         if ($response->getStatusCode() !== 200) {
-            throw new AccessTokenException('Fetching access token failed.');
+            throw new AccessTokenException(
+                'Fetching access token failed.', 
+                $this->scopeStrategy->getScopes()
+            );
         }
 
         $decoded = json_decode(
@@ -55,6 +58,9 @@ public function fetch(): AccessToken
             return new AccessToken($decoded['access_token'], $decoded['expires_in']);
         }
 
-        throw new AccessTokenException('Invalid access token');
+        throw new AccessTokenException(
+            'Invalid access token', 
+            $this->scopeStrategy->getScopes()
+        );
     }
 }

src/Informat/Exceptions/AccessTokenException.php

@@ -4,4 +4,19 @@
 
 class AccessTokenException extends InformatException
 {
+    /**
+     * @param string[] $scopes
+     */
+    public function __construct(string $message, protected array $scopes)
+    {
+        parent::__construct($message);
+    }
+
+    /**
+     * @return string[]
+     */
+    public function getScopes(): array
+    {
+        return $this->scopes;
+    }
 }

src/Informat/Responses/Personnel/Address.php

@@ -26,7 +26,7 @@ class Address
     public string $postcode;
 
     /** Submunicipality. */
-    public string $gemeente;
+    public ?string $gemeente;
 
     /** Official country code. */
     public string $landCode;

src/Informat/Responses/Personnel/Ambt.php

@@ -5,8 +5,8 @@
 class Ambt
 {
     /** Code of employee’s main function. */
-    public string $code;
+    public ?string $code;
 
     /** Description of employee’s main function. */
-    public string $naam;
+    public ?string $naam;
 }

src/Informat/Responses/Personnel/Bank.php

@@ -11,5 +11,5 @@ class Bank
      * Employee’s Bank Identification Code. 
      * Format: 8 to 11 characters if provided.
      */
-    public string $bic;
+    public ?string $bic;
 }

src/Informat/Responses/Personnel/Child.php

@@ -20,7 +20,7 @@ class Child
     public Sex $geslacht;
 
     /** Child’s date of birth. */
-    public string $geboortedatum;
+    public ?DateTime $geboortedatum;
 
     /** Indicates whether the child is deceased. */
     public bool $isOverleden;

src/Informat/Responses/Personnel/Employee.php

@@ -24,13 +24,13 @@ class Employee
     public string $voornaam;
 
     /** Employee’s additional names. */
-    public string $bijkomendeVoornamen;
+    public ?string $bijkomendeVoornamen;
 
     /**
      * Employee’s stamnummer.
      * Format: 11 characters (digits)
      */
-    public string $stamnr;
+    public ?string $stamnr;
 
     /** Employee’s sortable name. */
     public string $sortName;
@@ -42,25 +42,25 @@ class Employee
     public Sex $geslacht;
 
     /** Employee’s initials. */
-    public string $initialen;
+    public ?string $initialen;
 
     /** Employee’s date of birth. */
     public DateTime $geboortedatum;
 
     /** Employee’s place of birth. */
-    public string $geboorteplaats;
+    public ?string $geboorteplaats;
 
     /** Employee’s official country of birth code. */
     public string $geboortelandCode;
 
     /** Employee’s official nationality code. */
-    public string $nationaliteitCode;
+    public ?string $nationaliteitCode;
 
     /** 
      * Employee’s national registration number for Belgium residents. 
      * Format: ”yymmddxxxxx” if provided
      */
-    public string $rijksregisternr;
+    public ?string $rijksregisternr;
 
     /** 
      * Employee’s national registration number for a foreign person.
@@ -109,7 +109,7 @@ class Employee
     public ?DateTime $datumOverleden;
 
     /** Employee’s civil status. */
-    public BurgerlijkeStand $burgStand;
+    public ?BurgerlijkeStand $burgStand;
 
     /** Single object representing employee’s partner. */
     public ?Partner $partner;

src/Informat/Responses/Personnel/Partner.php

@@ -14,7 +14,7 @@ class Partner
     public string $naam;
 
     /** Partner’s first name. */
-    public string $voornaam;
+    public ?string $voornaam;
 
     /** Partner’s date of birth. */
     public ?DateTime $geboortedatum;