Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.5-beta Gamma Bug #14

Open
Jofoyo opened this issue Oct 17, 2024 · 2 comments
Open

v2.0.5-beta Gamma Bug #14

Jofoyo opened this issue Oct 17, 2024 · 2 comments
Labels
bug Something isn't working extremely bad Something is really wrong here

Comments

@Jofoyo
Copy link

Jofoyo commented Oct 17, 2024

Repro Settings
Windows 10
EP2/P/TF2
Model Phong+Envmap

Gamma settings are currently scaled incorrectly. This is also seen in the file preview.
Normal map green channel is also flipped after gamma is applied which results in an overbright green channel but isn't a problem if gamma correction isn't applied anyway.

image

@koerismo
Copy link
Owner

Hello! This gamma "correction" is not at all intentional, and seems to come from the way that Qt reads images. I have no idea why this happens or how to fix it.

@koerismo koerismo added bug Something isn't working extremely bad Something is really wrong here labels Oct 17, 2024
@Jofoyo
Copy link
Author

Jofoyo commented Oct 18, 2024

Hello! This gamma "correction" is not at all intentional, and seems to come from the way that Qt reads images. I have no idea why this happens or how to fix it.

I've done some additional repro testing. This seems to be related to embedded color management profiles in the texture file. After resaving the file with and without embedded ICC from Photoshop, the version without had proper gamma. This is apparent both on jpeg and png. This is also why I didn't notice it before, and that's my bad for using a different texture set to test, as the former was not color managed.

I believe color management can usually be discarded for texture applications like this, and there should be a way to do this with your IO library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extremely bad Something is really wrong here
Projects
None yet
Development

No branches or pull requests

2 participants