Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to npm namespacewrapper #68

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Switch to npm namespacewrapper #68

merged 5 commits into from
Jul 5, 2024

Conversation

labrocadabro
Copy link
Contributor

fixes #64

@labrocadabro labrocadabro mentioned this pull request Jul 3, 2024
Closed
@marsrobertson
Copy link
Contributor

Does it work though?

This is what we require: const { namespaceWrapper } = require('koii-task-node');

This is what we add:

    "@_koii/namespace-wrapper": "^1.0.1",
    "@_koii/storage-task-sdk": "^1.2.4",

Need to add koii-task-node in order to require('koii-task-node').

That was my first intuitive look, but don't trust verify and in fact it is not working.

  1. Checked-our your branch
  2. Navigate /Users/m/Code/ezsandbox/Lesson 1/EZ-testing-task
  3. npm install (new packages installed)
  4. Error message:
ERROR in ./coreLogic.js 1:29-54
Module not found: Error: Can't resolve 'koii-task-node' in '/Users/m/Code/ezsandbox/Lesson 1/EZ-testing-task'

ERROR in ./index.js 6:4-29
Module not found: Error: Can't resolve 'koii-task-node' in '/Users/m/Code/ezsandbox/Lesson 1/EZ-testing-task'

ERROR in ./task/audit.js 1:29-54
Module not found: Error: Can't resolve 'koii-task-node' in '/Users/m/Code/ezsandbox/Lesson 1/EZ-testing-task/task'

ERROR in ./task/distribution.js 1:29-54
Module not found: Error: Can't resolve 'koii-task-node' in '/Users/m/Code/ezsandbox/Lesson 1/EZ-testing-task/task'

ERROR in ./task/submission.js 1:29-54
Module not found: Error: Can't resolve 'koii-task-node' in '/Users/m/Code/ezsandbox/Lesson 1/EZ-testing-task/task'

@labrocadabro
Copy link
Contributor Author

Oh shoot, I was in a bit of a hurry and just followed the instructions without really thinking about it: https://www.npmjs.com/package/@_koii/namespace-wrapper

will take a close look tomorrow

@somali0128
Copy link
Member

LGTM then!

@somali0128 somali0128 merged commit 2d06fdb into koii-network:main Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to using namespaceWrapper package
3 participants
@labrocadabro @marsrobertson @somali0128