Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Не применяются пропсы ModalPage #19

Open
evgq opened this issue Nov 18, 2023 · 0 comments
Open

Не применяются пропсы ModalPage #19

evgq opened this issue Nov 18, 2023 · 0 comments
Assignees
@reyzitwo
Labels
bug Something isn't working

Comments

@evgq
Copy link

evgq commented Nov 18, 2023

ФР:
При обëртывании модалок в ModalRoot из роутера, нельзя указать onClose, onClosed для определëнной модалки. Скорее всего роутер передаëт значение onClose из ModalRoot

ОР:
Если передавать пропсы для отдельной модалки, то они должны учитываться, а в ModalRoot – нет. Ну или как сделано в VKUI, точно не скажу.
@reyzitwo reyzitwo self-assigned this Nov 19, 2023
@reyzitwo reyzitwo added the bug Something isn't working label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyzitwo reyzitwo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reyzitwo @evgq