style: apply lint

Author: kokororin

.eslintrc.cjs

@@ -10,7 +10,7 @@ module.exports = {
     browser: false,
     node: true
   },
-  plugins: ['import'],
+  plugins: ['import', 'unicorn'],
   extends: [
     'standard-with-typescript',
     'plugin:import/recommended',
@@ -44,7 +44,14 @@ module.exports = {
     ],
     '@typescript-eslint/restrict-template-expressions': 'off',
     '@typescript-eslint/no-unsafe-argument': 'off',
-    '@typescript-eslint/unbound-method': 'off'
+    '@typescript-eslint/unbound-method': 'off',
+    'unicorn/prefer-node-protocol': 'error',
+    'unicorn/catch-error-name': [
+      'error',
+      {
+        name: 'err'
+      }
+    ]
   },
   settings: {
     'import/parsers': {

.github/workflows/release.yml

@@ -1,6 +1,9 @@
 name: Release
 
 on:
+  push:
+    branches:
+      - master
   schedule:
     - cron: "*/30 * * * *"
 

package.json

@@ -643,6 +643,7 @@
     "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^5.1.3",
     "eslint-plugin-promise": "^6.1.1",
+    "eslint-plugin-unicorn": "^53.0.0",
     "fast-glob": "^3.3.2",
     "md5": "^2.3.0",
     "mocha": "^10.3.0",

pnpm-lock.yaml

@@ -1,5 +1,5 @@
-import path from 'path';
-import fs from 'fs/promises';
+import path from 'node:path';
+import fs from 'node:fs/promises';
 import phpfmt from 'phpfmt';
 
 void (async () => {

scripts/copy.ts

@@ -1,6 +1,6 @@
-import path from 'path';
-import os from 'os';
-import fs from 'fs/promises';
+import path from 'node:path';
+import os from 'node:os';
+import fs from 'node:fs/promises';
 import phpfmt from 'phpfmt';
 import { Transformation } from '../src/Transformation';
 

scripts/docs.ts

@@ -1,9 +1,9 @@
 /* eslint-disable n/no-sync */
 /* eslint no-console: error */
-import path from 'path';
-import os from 'os';
-import { execSync } from 'child_process';
-import fs from 'fs/promises';
+import path from 'node:path';
+import os from 'node:os';
+import { execSync } from 'node:child_process';
+import fs from 'node:fs/promises';
 import phpfmt from 'phpfmt';
 import AdmZip from 'adm-zip';
 import md5 from 'md5';
@@ -20,38 +20,6 @@ const changelogPath = path.join(__dirname, '../CHANGELOG.md');
 
 void (async () => {
   try {
-    // Publish to NPM
-    try {
-      execSync('npm publish --ignore-scripts', {
-        stdio: 'inherit',
-        env: {
-          NODE_AUTH_TOKEN: process.env.NODE_AUTH_TOKEN
-        }
-      });
-    } catch (err) {
-      consola.error(err);
-    }
-
-    // Publish to VSCE
-    try {
-      execSync(`vsce publish -p ${process.env.VSCE_TOKEN} --no-dependencies`, {
-        stdio: 'inherit'
-      });
-    } catch (err) {
-      consola.error(err);
-    }
-
-    // Publish to OVSX
-    try {
-      execSync(`ovsx publish -p ${process.env.OVSX_TOKEN} --no-dependencies`, {
-        stdio: 'inherit'
-      });
-    } catch (err) {
-      consola.error(err);
-    }
-
-    process.exit(1);
-
     const pkg = JSON.parse(String(await fs.readFile(pkgJsonPath)));
     const currentVersion = pkg.version;
 
@@ -145,6 +113,36 @@ ${changelogData}`;
       .addTag(`v${newVersion}`)
       .push()
       .pushTags();
+
+    // Publish to NPM
+    try {
+      execSync('npm publish --ignore-scripts', {
+        stdio: 'inherit',
+        env: {
+          NODE_AUTH_TOKEN: process.env.NODE_AUTH_TOKEN
+        }
+      });
+    } catch (err) {
+      consola.error(err);
+    }
+
+    // Publish to VSCE
+    try {
+      execSync(`vsce publish -p ${process.env.VSCE_TOKEN} --no-dependencies`, {
+        stdio: 'inherit'
+      });
+    } catch (err) {
+      consola.error(err);
+    }
+
+    // Publish to OVSX
+    try {
+      execSync(`ovsx publish -p ${process.env.OVSX_TOKEN} --no-dependencies`, {
+        stdio: 'inherit'
+      });
+    } catch (err) {
+      consola.error(err);
+    }
   } catch (err) {
     consola.error(err);
     process.exit(1);

scripts/release.ts

@@ -1,7 +1,7 @@
 import { workspace as Workspace, window as Window } from 'vscode';
-import path from 'path';
-import fs from 'fs/promises';
-import os from 'os';
+import path from 'node:path';
+import fs from 'node:fs/promises';
+import os from 'node:os';
 import detectIndent from 'detect-indent';
 import findUp from 'find-up';
 import { compare } from 'compare-versions';

src/PHPFmt.ts

@@ -1,4 +1,4 @@
-import os from 'os';
+import os from 'node:os';
 import mem from 'mem';
 import phpfmt, { type PHPFmt as IPHPFmt } from 'phpfmt';
 import { exec } from './utils';

src/Transformation.ts

@@ -1,6 +1,6 @@
-import childProcess, { type ExecOptions } from 'child_process';
-import fs, { type ObjectEncodingOptions } from 'fs';
-import https from 'https';
+import childProcess, { type ExecOptions } from 'node:child_process';
+import fs, { type ObjectEncodingOptions } from 'node:fs';
+import https from 'node:https';
 
 export async function exec(
   command: string,

src/utils.ts

@@ -1,5 +1,5 @@
-import path from 'path';
-import assert from 'assert';
+import path from 'node:path';
+import assert from 'node:assert';
 import { runTests } from '@vscode/test-electron';
 import findUp from 'find-up';
 

test/runTest.ts

@@ -1,4 +1,4 @@
-import assert from 'assert';
+import assert from 'node:assert';
 import fg from 'fast-glob';
 import {
   workspace as Workspace,

test/suite/extension.test.ts

@@ -1,5 +1,5 @@
 /* eslint-disable n/no-sync */
-import * as path from 'path';
+import * as path from 'node:path';
 import Mocha from 'mocha';
 import { sync as globSync } from 'fast-glob';