Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug/Info output causes issues #56

Open
amulet1 opened this issue Feb 22, 2025 · 1 comment
Open

Debug/Info output causes issues #56

amulet1 opened this issue Feb 22, 2025 · 1 comment

Comments

@amulet1
Copy link
Collaborator

amulet1 commented Feb 22, 2025

We need to redesign logging as there are multiple cases when an output of a particular command that calls the plugin is captured/analyzed. Injected debug or info messages there cause issues/errors.

For example, qm showcmd <vmid> is one example of such command. It output a kvm command line with parameters for a VM, but if the debug is enabled, there will be multiple Debug :: ... lines prepended. There are many other cases like that.

A possible solution is to use syslog for any plugin output.

@timansky
Copy link
Collaborator

I'm agree that syslog can be more informative, but ui log are also important.
Idea was to understand which log are necessary.
For user choice atleast log level need to be implemented. Info|warn|error|(debug for syslog| debug for ui)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants