Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive invocation of executor: doesn't shut down after finishing Runnable #1

Open
kolesroma opened this issue Nov 20, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@kolesroma
Copy link
Owner

I pass the folder path to method iterateRecursive(String folderPath). If in folder there is another one, it creates a new Runnable and recusively invoce same method. The problem is when root Runnable finishes its work, the other Runnable may not finish yet

public class FileService {

    public void iterateRecursive(String folderPath) {
        File fileFolder = new File(folderPath);
        for (File file : fileFolder.listFiles()) {
            if (file.isDirectory()) {
                executor.submit(() -> iterateRecursive(file.getPath()));
            } else {
                findNotesAndSaveToFile(file.getPath());
            }
        }
        try {
            // problem is here
            // so I just wait a few seconds and then shut down an executor manually
            TimeUnit.SECONDS.sleep(5);
            executor.shutdown();
        } catch (InterruptedException e) {
            e.printStackTrace();
            throw new RuntimeException(e);
        }
    }

}
@kolesroma kolesroma added the bug Something isn't working label Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant