Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleguide generator improvements #152

Open
3 of 5 tasks
nicolas-brousse opened this issue Nov 20, 2019 · 1 comment
Open
3 of 5 tasks

Styleguide generator improvements #152

nicolas-brousse opened this issue Nov 20, 2019 · 1 comment

Comments

@nicolas-brousse
Copy link
Member

nicolas-brousse commented Nov 20, 2019

  • don't do nested css on komponent styleguide components, since postcss-nested (or postcss-nesting) is not installed by default with webpacker
  • Add a style.css stylesheet file at frontend/components/komponent/ to have generic css like (body { margin: 0; }
  • Add link to Styleguide in header
  • Use rouge or an other, to colorize cdoc printed code

Others ideas

  • List properties as table with required and default value at beginning or end of a component page
@nicolas-brousse
Copy link
Member Author

I was thinking a bit more about the styleguide those days and I'm not sure if having styleguide always in application side is a good idea.
Having it customizable is a good idea, but not sure it is by default. I think that I could be a pain to keep styleguide up-to-date in future.

I've an alternative proposal.

  • Stop using components for headers, sidebar, footer, header. All this html could be in layout.
  • Having all styleguide component html, css in gem
  • Having generator only update routes and create the pack file that load js and css present in gem (not sure if that is easy)

To let user do customization, we could do the following

  • Having an option in generator to create views files (like devise do)
  • Use css variables for colors and fonts
  • Make views should be loaded from app first, then gem. To be sure we can overwrite views from app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant