Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a file for (S)CSS variables on install #88

Open
Spone opened this issue Apr 11, 2018 · 0 comments
Open

Create a file for (S)CSS variables on install #88

Spone opened this issue Apr 11, 2018 · 0 comments

Comments

@Spone
Copy link
Collaborator

Spone commented Apr 11, 2018

When we run rails g komponent:install, let's create a file in frontend/base/variables.(s)css

When we generate a component, we should @import the variables file by default in the generated (S)CSS file. Make sure that the path is right (especially for nested components).

Or maybe we could add some configuration to be able to always import with @import "base/variables";
It's possible with https://github.com/postcss/postcss-import but we have to check with Sass.

@Spone Spone added this to the 2.0.0.pre.1 milestone Apr 11, 2018
@Spone Spone mentioned this issue Apr 11, 2018
@Spone Spone removed this from the 2.0.0.pre.1 milestone Apr 11, 2018
@florentferry florentferry added this to the 2.0.0.pre.2 milestone Apr 12, 2018
@florentferry florentferry removed this from the 2.0.1 milestone May 31, 2018
@Spone Spone modified the milestone: 3.0 Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants