Skip to content

Latest commit

 

History

History
86 lines (58 loc) · 4.42 KB

0024-release-attribution.md

File metadata and controls

86 lines (58 loc) · 4.42 KB
Raw

24. Release Objects Attribution Tracking and Propagation

Date: 2023-04-25

Status

Accepted

Context

It is imperative to know, given a change that has been delivered to a production environment, which individual it can be attributed to, in order to have accountability for that change. This information needs to be propagated through the release process and needs to be flexible enough to specify attribution either on a per-release basis or as a standing attribution.

Decision

An admission webhook will be used to capture and track the user information provided in the Kubernetes request. This user will be validated against Red Hat's SSO.

Architecture Overview

Terminology

  • Release: A CRD that describes what should be released and using which plan.
  • ReleasePlan: A CRD that describes where an application should be released.
  • ReleasePlanAdmission: A CRD that describes which pipeline to execute along with specific pipeline parameters.

Architecture

Capturing attribution data

The end goal of the ADR is to permit the release-service's Pipeline's Tasks to have access to the name of the individual to which a change in production can be attributed. There are two kinds of attribution involved:

Attribution for a particular Release

It will be obtained by capturing the user that created the object. This information is available for requests intercepted by admission webhooks. The Release CR will be updated with the label release.rhtap.openshift.io/author using the username that triggered the requests as its value.

As automated Releases would also obtain this label, it's important to add a new label to indicate their nature. Automated Releases are exclusively created by the Integration service, which will have to add the label release.rhtap.openshift.io/automated and set it to true so the author label is not set in the webhook.

Standing Attribution for an Application

It will be obtained by capturing the user that creates or updates the ReleasePlan CR. This will be done exclusively when the resource has the label release.rhtap.openshift.io/standing-attribution set to true.

Since we expect ReleasePlans to be updated by users who may not intend to provide a Standing Attribution (i.e. Change ReleasePlanAdmission), it is important to keep track of author information when the annotation is set. ReleasePlans will make use of the same label described above (release.rhtap.openshift.io/author) to keep track of the user information.

Changes in the Release reconciliation

The inclusion of attribution labels expands the validation phase. When a Release is reconciled, it must follow this process:

  • Verify that the release.rhtap.openshift.io/author label is present.
    • If not present, consult the ReleasePlan to look if it is present there.
    • If the author information is not present in either of them, fail with ValidationError.
    • If found, copy the author label to the Release and add the status.attribution.author. The field status.attribution.standingAttribution should be also set to true in the case the author is coming from the ReleasePlan.
  • Verify if the author is a "real" User as opposed to a ServiceAccount. Given an author value, the system will query the SSO service to determine that the user is known for the SSO service. This rules out kube:admin and any other service account. It will also help weed out the cases where the user has left the organization.
  • Update status.attribution.verified and set it to true if verification passed. Otherwise, fail with a ValidationError.

At this point, the status.attribution will be populated and the author is validated to be a real user. The Release Service operator makes the Release along with the attribution info available to the Release Pipelines.

This validation process will not be performed when status.attribution.verified is set to true to reduce the number of requests to the SSO service.

Removing attribution data

A Standing Attribution for an Application can be deleted by a user when the ReleasePlan CR has the label release.rhtap.openshift.io/standing-attribution set to false or removed.

Consequences

  • The SSO service interaction must be adequately efficient to ensure the Release process is not delayed.
  • The system needs to handle the situation whereby a User specified in the ReleasePlan is not longer a valid user.